Issue 313990043: TBR: i#2006 generalize drcachesim: add branch type info

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 313990043: TBR: i#2006 generalize drcachesim: add branch type info

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by bruening

Modified:
7 years, 5 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2006 generalize drcachesim: add branch type info Adds info on branch types to instruction fetch trace entries. This is on by default for offline, but off by default for online under a new option -online_instr_types as it incurs overhead (which we could avoid via separate bundle types but it's not worth it until we have online tools asking for this information). ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -8 lines)			Patch
M	clients/drcachesim/common/memref.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcachesim/common/options.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	clients/drcachesim/common/options.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	clients/drcachesim/common/trace_entry.h	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	clients/drcachesim/common/trace_entry.cpp	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	clients/drcachesim/reader/reader.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	clients/drcachesim/simulator/cache_simulator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcachesim/simulator/tlb_simulator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcachesim/tools/histogram.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcachesim/tracer/instru.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	clients/drcachesim/tracer/instru.cpp	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	clients/drcachesim/tracer/instru_online.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcachesim/tracer/raw2trace.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcachesim/tracer/tracer.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 5 months ago (2016-10-31 16:38:37 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/4fc4ac4dde1dcb024f95e89c03373b3...

Final commit log: 
---------------
i#2006 generalize drcachesim: add branch type info

Adds info on branch types to instruction fetch trace entries.  This is on
by default for offline, but off by default for online under a new option
-online_instr_types as it incurs overhead (which we could avoid via
separate bundle types but it's not worth it until we have online tools
asking for this information).

Review-URL: https://codereview.appspot.com/313990043
---------------

Expand All Messages | Collapse All Messages