Issue 313900043: TBR: Fix build failure introduced in 354960a

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 313900043: TBR: Fix build failure introduced in 354960a

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by zhaoqin

Modified:
7 years, 6 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Fix build failure introduced in 354960a Cast tids[tidx] to uint for printing. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	clients/drcachesim/tracer/raw2trace.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhaoqin

Committed as https://github.com/DynamoRIO/dynamorio/commit/926b8ebd43ee5ef22a2e4f75105bfec11b2914c3 Final commit log: --------------- Fix build failure introduced in 354960a Cast tids[tidx] ...

7 years, 6 months ago (2016-10-21 01:20:02 UTC) #2

bruening

7 years, 6 months ago (2016-10-21 02:05:56 UTC) #3

On 2016/10/21 01:20:02, zhaoqin wrote:
> Committed as
>
https://github.com/DynamoRIO/dynamorio/commit/926b8ebd43ee5ef22a2e4f75105bfec...
> 
> Final commit log: 
> ---------------
> Fix build failure introduced in 354960a
> 
> Cast tids[tidx] to uint for printing.
> 
> Review-URL: https://codereview.appspot.com/313900043
> ---------------

LGTM

Thanks for fixing this.  I thought I had time to see the Travis results before
heading to the airport but it's been getting slower and slower: now taking 45
mins instead of 22 mins.

Expand All Messages | Collapse All Messages