Issue 313560043: Final updates to correct doxygen warnings for the wifi module (Closed)
|
Created:
7 years, 7 months ago by ammo6818-vandals.uidaho.edu Modified:
6 years, 8 months ago Reviewers:
S. Deronne CC:
ns-3-reviews_googlegroups.com Visibility:
Public. |
DescriptionFinal updates to correct doxygen warnings for the wifi module
Patch Set 1 #Patch Set 2 : Updates to correct doxygen warnings for latest external merge #
Total comments: 91
Patch Set 3 : Doxygen warning correction #Patch Set 4 : Additional doxygen corrections #Patch Set 5 : Additional doxygen corrections #
Total comments: 24
Patch Set 6 : Additional doxygen corrections for the latest updates #MessagesTotal messages: 6
https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/athstats-... File src/wifi/helper/athstats-helper.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/athstats-... src/wifi/helper/athstats-helper.h:50: * \param filename the fiel name file https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... File src/wifi/helper/qos-wifi-mac-helper.h (left): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:183: void Setup (Ptr<WifiMac> mac, enum AcIndex ac, std::string dcaAttrName) const; edcaAttrName https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... File src/wifi/helper/qos-wifi-mac-helper.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:173: ObjectFactory m_mac; ///< MAC object factory MAC object https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:186: * \param ac the AC index the access category https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:187: * \param dcaAttrName the DCA attribute name edcaAttrName the EDCA attribute name (VO_EdcaTxopN, VI_EdcaTxopN, BE_EdcaTxopN, BK_EdcaTxopN) https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:191: std::map<AcIndex, ObjectFactory> m_msduAggregators; ///< msdu aggregators A-MSDU aggregators https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:192: std::map<AcIndex, ObjectFactory> m_mpduAggregators; ///< mpdu aggregators A-MPDU aggregators https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:197: std::map<AcIndex, uint8_t> m_bAckThresholds; ///< ack thresholds Block ACK thresholds https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:198: std::map<AcIndex, uint16_t> m_bAckInactivityTimeouts; ///< ack inactivity timeouts Block ACK inactivity timeout https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/vht-wifi-... File src/wifi/helper/vht-wifi-mac-helper.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/vht-wifi-... src/wifi/helper/vht-wifi-mac-helper.cc:49: /// MPDU aggregation is always supported Those are deprecated and will be removed in the next release, so I do not support to add such comments here. https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/wifi-help... File src/wifi/helper/wifi-helper.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/wifi-help... src/wifi/helper/wifi-helper.cc:45: * \param txLevel the transmit level the transmit power level https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/wifi-help... src/wifi/helper/wifi-helper.cc:66: * \param txLevel the transmit level the transmit power level https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/wifi-help... File src/wifi/helper/wifi-helper.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/wifi-help... src/wifi/helper/wifi-helper.h:166: ObjectFactory m_phy; ///< Phy object factory PHY object https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/wifi-help... src/wifi/helper/wifi-helper.h:346: enum WifiPhyStandard m_standard; ///< phy standard wifi standard https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/yans-wifi... File src/wifi/helper/yans-wifi-helper.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/yans-wifi... src/wifi/helper/yans-wifi-helper.h:145: std::vector<ObjectFactory> m_propagationLoss; ///< propagation loss vector of propagation loss models https://codereview.appspot.com/313560043/diff/20001/src/wifi/helper/yans-wifi... src/wifi/helper/yans-wifi-helper.h:146: ObjectFactory m_propagationDelay; ///< propagation delay propagation delay model
Sign in to reply to this message.
No doxygen updates needed for wifi-phy-configuration example? How can I check doxygen warnings to be sure there is no ones remaining? https://codereview.appspot.com/313560043/diff/20001/src/wifi/examples/ideal-w... File src/wifi/examples/ideal-wifi-manager-example.cc (left): https://codereview.appspot.com/313560043/diff/20001/src/wifi/examples/ideal-w... src/wifi/examples/ideal-wifi-manager-example.cc:97: I am busy right now deleting this file and replacing by a common wifi manager example. I'll integrate Doxygen updates in the new example directly. https://codereview.appspot.com/313560043/diff/20001/src/wifi/examples/minstre... File src/wifi/examples/minstrel-ht-wifi-manager-example.cc (left): https://codereview.appspot.com/313560043/diff/20001/src/wifi/examples/minstre... src/wifi/examples/minstrel-ht-wifi-manager-example.cc:102: void I am busy right now deleting this file and replacing by a common wifi manager example. I'll integrate Doxygen updates in the new example directly. https://codereview.appspot.com/313560043/diff/20001/src/wifi/examples/wifi-ph... File src/wifi/examples/wifi-phy-test.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/examples/wifi-ph... src/wifi/examples/wifi-phy-test.cc:43: uint32_t packetSize; ///< packt size packet size
Sign in to reply to this message.
https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/dcf-manager... File src/wifi/test/dcf-manager-test.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/dcf-manager... src/wifi/test/dcf-manager-test.cc:58: typedef std::list<ExpectedGrant> ExpectedGrants; //!< the collection of expected grants typedef https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/dcf-manager... src/wifi/test/dcf-manager-test.cc:264: typedef std::vector<DcfStateTest *> DcfStates; //!< the DCF test states the DCF test states typedef https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/dcf-manager... src/wifi/test/dcf-manager-test.cc:265: typedef std::vector<Ptr<DcaTxopTest> > Dca; //!< the DCA TXOP test the DCA TXOP tests typedef https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/spectrum-wi... File src/wifi/test/spectrum-wifi-phy-test.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/spectrum-wi... src/wifi/test/spectrum-wifi-phy-test.cc:57: * \param txPowerWatts the transmit power watts the transmit power in watts https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/spectrum-wi... src/wifi/test/spectrum-wifi-phy-test.cc:63: * \param txPowerWatts the transmit power watts the transmit power in watts https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... File src/wifi/test/wifi-aggregation-test.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... src/wifi/test/wifi-aggregation-test.cc:48: Ptr<MacLow> m_low; ///< low MacLow https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... src/wifi/test/wifi-aggregation-test.cc:51: MacTxMiddle *m_txMiddle; ///< tramsit middle MacTxMiddle https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... src/wifi/test/wifi-aggregation-test.cc:54: Ptr<MpduAggregator> m_mpduAggregator; ///< MPDU aggregrator A-MPDU aggregator https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... src/wifi/test/wifi-aggregation-test.cc:264: Ptr<MacLow> m_low; ///< low MacLow https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... src/wifi/test/wifi-aggregation-test.cc:269: Ptr<MsduAggregator> m_msduAggregator; ///< MSDU aggregator A-MSDU aggregator https://codereview.appspot.com/313560043/diff/20001/src/wifi/test/wifi-aggreg... src/wifi/test/wifi-aggregation-test.cc:270: Ptr<MpduAggregator> m_mpduAggregator; ///< MPDU aggregator A-MPDU aggregator
Sign in to reply to this message.
https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/amsdu-subf... File src/wifi/model/amsdu-subframe-header.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/amsdu-subf... src/wifi/model/amsdu-subframe-header.h:52: * Set destination addresss function address https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/amsdu-subf... src/wifi/model/amsdu-subframe-header.h:72: * Get source addresss function address https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/ap-wifi-mac.h File src/wifi/model/ap-wifi-mac.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/ap-wifi-ma... src/wifi/model/ap-wifi-mac.h:113: * \returns the short time slot enabled flag. \returns whether short slot time should be enabled or not in the BSS. https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/ap-wifi-ma... src/wifi/model/ap-wifi-mac.h:121: * \returns the short preamble enabled flag. \returns whether short preamble should be enabled or not in the BSS. https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/ap-wifi-ma... src/wifi/model/ap-wifi-mac.h:127: * \returns the is non GFHT STAS present flag. \returns whether non-Greenfield HT stations are present or not. https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... File src/wifi/model/block-ack-cache.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-cache.h:89: uint16_t m_bitmap[4096]; ///< ack bitmap bitmap https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... File src/wifi/model/block-ack-manager.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:61: uint8_t tid; ///< TID traffic ID https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:259: * Set transmit middle Set MacTxMiddle https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:260: * \param txMiddle the MAC transmit middle the MacTxMiddle https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:358: * \param tid TID traffic ID https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:368: * \param tid TID traffic ID https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:419: * \param tid the TID traffic ID https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:500: MacTxMiddle* m_txMiddle; ///< transmit middle MacTxMiddle https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dca-txop.h File src/wifi/model/dca-txop.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dca-txop.h... src/wifi/model/dca-txop.h:393: MacTxMiddle *m_txMiddle; //!< the MAC transmit middle the MacTxMiddle https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dca-txop.h... src/wifi/model/dca-txop.h:394: Ptr <MacLow> m_low; //!< the MAC low the MacLow https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-manager.h File src/wifi/model/dcf-manager.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-manage... src/wifi/model/dcf-manager.h:342: bool m_rxing; //!< is receiving? flag whether it is in receiving state https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-manage... src/wifi/model/dcf-manager.h:343: bool m_sleeping; //!< is sleeping? flag whether it is in sleeping state https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-manage... src/wifi/model/dcf-manager.h:346: uint32_t m_slotTimeUs; //!< the slot time us the slot time in microseconds https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-state.h File src/wifi/model/dcf-state.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-state.... src/wifi/model/dcf-state.h:200: uint32_t m_cw; //!< the CW the current CW https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dcf-state.... src/wifi/model/dcf-state.h:202: bool m_accessRequested; //!< access requested? flag whether channel access is already requested https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dsss-param... File src/wifi/model/dsss-parameter-set.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/dsss-param... src/wifi/model/dsss-parameter-set.h:101: uint8_t m_currentChannel; ///< current channel current channel number https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-param... File src/wifi/model/edca-parameter-set.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-param... src/wifi/model/edca-parameter-set.h:395: uint32_t m_acBE; ///< ACBE AC_BE https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-param... src/wifi/model/edca-parameter-set.h:396: uint32_t m_acBK; ///< ACBK AC_BK https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-param... src/wifi/model/edca-parameter-set.h:397: uint32_t m_acVI; ///< ACVI AC_VI https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-param... src/wifi/model/edca-parameter-set.h:398: uint32_t m_acVO; ///< ACVO AC_VO https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-n.h File src/wifi/model/edca-txop-n.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:74: std::map<Mac48Address, bool> m_aMpduEnabled; //!< the AMPDU enabled list list containing flags whether A-MPDU is enabled for a given destination address https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:344: * \returns true if the AMPDU exists return true if A-MPDU is used by the peer station https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:542: AcIndex m_ac; //!< the AC index the access category https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:543: Ptr<MsduAggregator> m_msduAggregator; //!< MSDU aggregator A-MSDU aggregator https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:544: Ptr<MpduAggregator> m_mpduAggregator; //!< MPDU aggregator A-MPDU aggregator https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:554: bool m_isAccessRequestedForRts; //!< access requested for RTS? flag whether access is requested to transmit a RTS frame https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:555: bool m_currentIsFragmented; //!< is the current IS fragmented flag whether current packet is fragmented https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/interferen... File src/wifi/model/interference-helper.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/interferen... src/wifi/model/interference-helper.h:100: WifiTxVector m_txVector; ///< transmit vector TXVECTOR https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/interferen... src/wifi/model/interference-helper.h:103: double m_rxPowerW; ///< receive power receive power in watts https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/interferen... src/wifi/model/interference-helper.h:324: bool m_rxing; ///< receiving flag whether it is in receiving state https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h File src/wifi/model/mac-low.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1014: * \param tid the TID Traffic ID https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1016: * \param duration the duration the remaining NAV duration https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1061: * \returns true if is AMPDU A-MPDU https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1068: * \param packet packet to check whether it can be aggregated in an A-MPDU packet to be inserted in the A-MPDU tx queue https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1069: * \param hdr 802.11 header for packet to check whether it can be aggregated in an A-MPDU 802.11 header for the packet to be inserted in the A-MPDU tx queue https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1070: * \param tStamp timestamp timestamp of the packet to be inserted in the A-MPDU tx queue https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1071: * \param tid the TID Traffic ID of the packet to be inserted in the A-MPDU tx queue https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1163: Agreements m_bAckAgreements; //!< ack agreements block ack agreements https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1166: typedef std::map<AcIndex, Ptr<EdcaTxopN> > QueueEdcas; //!< EDCA queue typedef EDCA queues typedef https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-low.h#... src/wifi/model/mac-low.h:1167: QueueEdcas m_edca; //!< EDCA queue EDCA queues https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-rx-mid... File src/wifi/model/mac-rx-middle.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-rx-mid... src/wifi/model/mac-rx-middle.cc:46: bool m_defragmenting; ///< defragmenting? flag to indicate whether we are defragmenting https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-tx-mid... File src/wifi/model/mac-tx-middle.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/mac-tx-mid... src/wifi/model/mac-tx-middle.h:71: uint16_t m_sequence; ///< sequence current sequence number https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/originator... File src/wifi/model/originator-block-ack-agreement.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/originator... src/wifi/model/originator-block-ack-agreement.h:44: * \param tid TID Traffic ID https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/originator... src/wifi/model/originator-block-ack-agreement.h:160: bool m_needBlockAckReq; ///< need block ack request flag whether it needs a Block ACK request https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... File src/wifi/model/regular-wifi-mac.h (left): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... src/wifi/model/regular-wifi-mac.h:617: AMPDU => A-MPDU A-MSDU => A-MSDU VI => AC_VI VO => AC_VO BE => AC_BE BK => AC_BK https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... File src/wifi/model/regular-wifi-mac.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... src/wifi/model/regular-wifi-mac.h:693: uint32_t m_bkMaxAmsduSize; ///< BK maximum AMSDU size maximum A-MSDU size for ... https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... src/wifi/model/regular-wifi-mac.h:698: uint32_t m_bkMaxAmpduSize; ///< BK maximum AMPDU size maximum A-MPDU size for ... https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... src/wifi/model/regular-wifi-mac.h:703: bool m_shortSlotTimeSupported; ///< short slot time supported flag whether short slot time is supporte https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/regular-wi... src/wifi/model/regular-wifi-mac.h:704: bool m_rifsSupported; ///< RIFS supported flag whether RIFS is supported https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-mode.h File src/wifi/model/wifi-mode.h (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-mode.... src/wifi/model/wifi-mode.h:324: bool isMandatory; ///< is mandatory? flag to indicate whether this mode is mandatory https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... File src/wifi/model/wifi-remote-station-manager.cc (right): https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.cc:50: * \param dataTxVector data transmit vector TXVECTOR for data frames https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.cc:69: WifiTxVector m_dataTxVector; ///< data transmit vector TXVECTOR for data frames https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.cc:138: * \param rtsTxVector wifi transmit vector TXVECTOR for RTS frames https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.cc:158: WifiTxVector m_rtsTxVector; ///< RTS transmit vector TXVECTOR for RTS frames https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.cc:227: * \param ctsToSelfTxVector wifi transmit vector TXVECTOR for CTS-to-self frames https://codereview.appspot.com/313560043/diff/20001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.cc:246: WifiTxVector m_ctsToSelfTxVector; ///< CTS to self transmit vector TXVECTOR for CTS-to-self frames
Sign in to reply to this message.
https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/ampdu-tag.h File src/wifi/model/ampdu-tag.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/ampdu-tag.... src/wifi/model/ampdu-tag.h:51: * \param supported the A-MPDU suppoted flag s/suppoted/supported https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/block-ack-... File src/wifi/model/block-ack-manager.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/block-ack-... src/wifi/model/block-ack-manager.h:355: * \returns true if the packet aready exists s/aready/already https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/ctrl-heade... File src/wifi/model/ctrl-headers.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/ctrl-heade... src/wifi/model/ctrl-headers.h:412: uint64_t m_compressedBitmap; ///< the compressed blcok ack bitmap s/blcok/block https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/dca-txop.h File src/wifi/model/dca-txop.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/dca-txop.h... src/wifi/model/dca-txop.h:252: * \param nMpdus the number of MPDUs that experienced a Block Ack timeout or maybe we can say something like this corresponds to the number of MPDUs sent in the A-MPDU transmission that results in a Block ACK timeout. For me your description is clear, but maybe not for somebody that knows less about MPDU aggregation and BACK. https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/edca-txop-n.h File src/wifi/model/edca-txop-n.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/edca-txop-... src/wifi/model/edca-txop-n.h:203: * \param nMpdus number of MPDUs you can maybe explain here also https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/interferen... File src/wifi/model/interference-helper.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/interferen... src/wifi/model/interference-helper.h:334: * \returns an iterator to the list of NiCHanges s/NiCHanges/NiChanges https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... File src/wifi/model/minstrel-ht-wifi-manager.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:268: * \param chWidth the channel width Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:279: * \param sgi the guard interval Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:280: * \param chWidth the channel width Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:291: * \param sgi the guard interval Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:292: * \param chWidth the channel width Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:556: * \param sgi the sgi Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:557: * \param chWidth the channel width Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:566: * \param sgi the sgi Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/minstrel-h... src/wifi/model/minstrel-ht-wifi-manager.h:567: * \param chWidth the channel width Best also to specify the units https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/mpdu-aggre... File src/wifi/model/mpdu-aggregator.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/mpdu-aggre... src/wifi/model/mpdu-aggregator.h:87: * \param last if the last packet. \param last if it is the last packet https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/mpdu-aggre... src/wifi/model/mpdu-aggregator.h:88: * \param isSingleMpdu true if a single MPDU \param isSingleMpdu true if it is a single MPDU https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/mpdu-stand... File src/wifi/model/mpdu-standard-aggregator.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/mpdu-stand... src/wifi/model/mpdu-standard-aggregator.h:78: * \param last if the last packet. \param last if it is the last packet. https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/mpdu-stand... src/wifi/model/mpdu-standard-aggregator.h:79: * \param isSingleMpdu true if a single MPDU \param isSingleMpdu true if it is a single MPDU https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/supported-... File src/wifi/model/supported-rates.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/supported-... src/wifi/model/supported-rates.h:237: * \param length the size of the information field units? https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/wifi-infor... File src/wifi/model/wifi-information-element-vector.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/wifi-infor... src/wifi/model/wifi-information-element-vector.h:74: * \param size the maximum size to set units? https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/wifi-mac.h File src/wifi/model/wifi-mac.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/wifi-mac.h... src/wifi/model/wifi-mac.h:204: * \return current attached WifiPhy device \return the currently attached WifiPhy device https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/wifi-remot... File src/wifi/model/wifi-remote-station-manager.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/model/wifi-remot... src/wifi/model/wifi-remote-station-manager.h:62: * \returns the frame erro rate s/erro/error
Sign in to reply to this message.
https://codereview.appspot.com/313560043/diff/80001/src/wifi/helper/qos-wifi-... File src/wifi/helper/qos-wifi-mac-helper.h (right): https://codereview.appspot.com/313560043/diff/80001/src/wifi/helper/qos-wifi-... src/wifi/helper/qos-wifi-mac-helper.h:56: * \returns a default QosWifiMcHelper extra space
Sign in to reply to this message.
|
