Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4948)

Issue 313450043: TBR: i#511 drreg: simplify usage by combining multiple inits

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by bruening
Modified:
7 years, 2 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#511 drreg: simplify usage by combining multiple inits Adds support for calling drreg_init() multiple times and combining the requests. Adds a new drreg option field, do_not_sum_slots, to support taking the maximum rather than summing, to support libraries requesting a minimum number of slots yet not adding to the simultaneous slots needed if the client is already using drreg directly. This simplifies the opcodes.c and stats.c clients, who no longer need to initialize drreg at all. This also simplifies the modxfer client, who can now not ask for slots. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -56 lines) Patch
M api/samples/modxfer.c View 1 chunk +5 lines, -2 lines 0 comments Download
M api/samples/opcodes.c View 4 chunks +5 lines, -8 lines 0 comments Download
M api/samples/stats.c View 3 chunks +2 lines, -6 lines 0 comments Download
M ext/drreg/drreg.h View 3 chunks +34 lines, -10 lines 0 comments Download
M ext/drreg/drreg.c View 2 chunks +54 lines, -26 lines 0 comments Download
M ext/drreg/drreg.dox View 1 chunk +4 lines, -3 lines 0 comments Download
M ext/drx/drx.c View 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 2
bruening
7 years, 2 months ago (2017-01-30 18:23:26 UTC) #1
bruening
7 years, 2 months ago (2017-01-30 18:23:28 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/583b2fc994169461d29dd4cc720f85d...

Final commit log: 
---------------
i#511 drreg: simplify usage by combining multiple inits

Adds support for calling drreg_init() multiple times and combining the
requests.

Adds a new drreg option field, do_not_sum_slots, to support taking the
maximum rather than summing, to support libraries requesting a minimum
number of slots yet not adding to the simultaneous slots needed if the
client is already using drreg directly.

This simplifies the opcodes.c and stats.c clients, who no longer need to
initialize drreg at all.

This also simplifies the modxfer client, who can now not ask for slots.

Review-URL: https://codereview.appspot.com/313450043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b