Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(946)

Issue 313000043: Fix drfuzz client build problem

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by zhaoqin
Modified:
7 years, 5 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- Fix drfuzz client build problem Moves #include "../framework/drmf.h" from drfuzz.h to drfuzz.c. ---------------

Patch Set 1 #

Patch Set 2 : update commit msg #

Patch Set 3 : update commit msg #

Patch Set 4 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M drfuzz/drfuzz.h View 1 chunk +0 lines, -1 line 0 comments Download
M drfuzz/drfuzz.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
zhaoqin
7 years, 5 months ago (2016-11-01 21:54:06 UTC) #1
bruening
What is the build problem? The commit message does not say what it is or ...
7 years, 5 months ago (2016-11-01 23:01:09 UTC) #2
zhaoqin
Commit log for latest patchset: --------------- Fix drfuzz client build problem When build a separate ...
7 years, 5 months ago (2016-11-02 00:03:12 UTC) #3
zhaoqin
On 2016/11/01 23:01:09, bruening wrote: > What is the build problem? The commit message does ...
7 years, 5 months ago (2016-11-02 00:03:55 UTC) #4
bruening
On 2016/11/02 00:03:12, zhaoqin wrote: > Commit log for latest patchset: > --------------- > Fix ...
7 years, 5 months ago (2016-11-02 14:40:19 UTC) #5
zhaoqin
Commit log for latest patchset: --------------- i#1924 drfuzz client build failure: remove "include drmf.h" from ...
7 years, 5 months ago (2016-11-02 14:58:33 UTC) #6
zhaoqin
7 years, 5 months ago (2016-11-02 15:23:50 UTC) #7
Committed as
https://github.com/DynamoRIO/drmemory/commit/fdbf2d997c0ca52c8d6ee0115ae7572d...

Final commit log: 
---------------
i#1924 drfuzz client build failure: remove "include drmf.h" from drfuzz.h

Moves #include "../framework/drmf.h" from drfuzz.h to drfuzz.c to fix
the build failure:
"drfuzz.h:40:31: fatal error: ../framework/drmf.h: No such file or directory"

Review-URL: https://codereview.appspot.com/313000043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b