[dfvfs] Add support for zip files with missing directory entries. #194

[dfvfs] Add support for zip files with missing directory entries.

[onager, 2017-06-01 02:42:02]

https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py
File dfvfs/vfs/zip_file_entry.py (right):

https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py#n...
dfvfs/vfs/zip_file_entry.py:32: # The zip_info filename does not have the
leading path separates
separator

https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py#n...
dfvfs/vfs/zip_file_entry.py:202: return self._file_system.BasenamePath(path)
basenamepath(None) crashes - please refactor this.

https://codereview.appspot.com/312700043/diff/1/tests/test_lib.py
File tests/test_lib.py (right):

https://codereview.appspot.com/312700043/diff/1/tests/test_lib.py#newcode43
tests/test_lib.py:43: """Helper function that asserts the sub file entries.
What does this mean? Is this mean to be "asserts that sub file entries are as
expected"?

[dc3.plaso, 2017-06-23 13:33:43]

https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py
File dfvfs/vfs/zip_file_entry.py (right):

https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py#n...
dfvfs/vfs/zip_file_entry.py:32: # The zip_info filename does not have the
leading path separates
On 2017/06/01 02:42:01, onager wrote:
> separator

Done.

https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py#n...
dfvfs/vfs/zip_file_entry.py:202: return self._file_system.BasenamePath(path)
On 2017/06/01 02:42:01, onager wrote:
> basenamepath(None) crashes - please refactor this.

Done.

https://codereview.appspot.com/312700043/diff/1/tests/test_lib.py
File tests/test_lib.py (right):

https://codereview.appspot.com/312700043/diff/1/tests/test_lib.py#newcode43
tests/test_lib.py:43: """Helper function that asserts the sub file entries.
On 2017/06/01 02:42:02, onager wrote:
> What does this mean? Is this mean to be "asserts that sub file entries are as
> expected"?

Changed to:
"Helper function that asserts the sub file entries have the expected names."

[dc3.plaso, 2017-06-23 13:34:42]

Code updated.

[onager, 2017-07-04 13:43:46]

On 2017/06/23 13:34:42, dc3.plaso wrote:
> Code updated.

OK, this LGTM. Merging

[onager, 2017-07-04 13:46:56]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
194-support-missing-zip-directory-entries