Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(529)

Issue 312700043: [dfvfs] Add support for zip files with missing directory entries. #194 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by dc3.plaso
Modified:
3 months ago
Reviewers:
onager
CC:
Joachim Metz, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Add support for zip files with missing directory entries.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Code review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -59 lines) Patch
M dfvfs/file_io/zip_file_io.py View 1 chunk +4 lines, -0 lines 0 comments Download
M dfvfs/vfs/tar_file_entry.py View 1 chunk +0 lines, -1 line 0 comments Download
M dfvfs/vfs/tar_file_system.py View 1 chunk +0 lines, -1 line 0 comments Download
M dfvfs/vfs/zip_file_entry.py View 1 4 chunks +57 lines, -18 lines 0 comments Download
M dfvfs/vfs/zip_file_system.py View 2 chunks +18 lines, -14 lines 0 comments Download
A test_data/missing_directory_entries.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/test_lib.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
M tests/vfs/tar_file_entry.py View 1 chunk +0 lines, -18 lines 0 comments Download
M tests/vfs/tar_file_system.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/vfs/zip_file_entry.py View 1 chunk +22 lines, -8 lines 0 comments Download
M tests/vfs/zip_file_system.py View 3 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dc3.plaso
5 months, 1 week ago (2017-05-16 15:17:23 UTC) #1
onager
https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py File dfvfs/vfs/zip_file_entry.py (right): https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py#newcode32 dfvfs/vfs/zip_file_entry.py:32: # The zip_info filename does not have the leading ...
4 months, 3 weeks ago (2017-06-01 02:42:02 UTC) #2
dc3.plaso
https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py File dfvfs/vfs/zip_file_entry.py (right): https://codereview.appspot.com/312700043/diff/1/dfvfs/vfs/zip_file_entry.py#newcode32 dfvfs/vfs/zip_file_entry.py:32: # The zip_info filename does not have the leading ...
3 months, 4 weeks ago (2017-06-23 13:33:43 UTC) #3
dc3.plaso
Code updated.
3 months, 4 weeks ago (2017-06-23 13:34:42 UTC) #4
onager
On 2017/06/23 13:34:42, dc3.plaso wrote: > Code updated. OK, this LGTM. Merging
3 months, 2 weeks ago (2017-07-04 13:43:46 UTC) #5
onager
3 months, 2 weeks ago (2017-07-04 13:46:56 UTC) #6
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
194-support-missing-zip-directory-entries
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted