Issue 312610043: ui/gtk3: Fix build failures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 312610043: ui/gtk3: Fix build failures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 7 months ago by fujiwara

Modified:
7 years, 7 months ago

Reviewers:
shawn.p.huang, Peng

CC:
Peng Wu

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Fix build failures ibus-ui-emoijer needs to be built at last in ui/gtk3 Also fixed po/POTFILES.in for `make dist` Now I moved libibusemojidialog.so and IBusEmojiDialog-1.0.[gir|typelib] and ibus-emoji-dialog-1.0.vapi to noinst because now ibus-ui-emojier is available and they are private libraries. R=Shawn.P.Huang@gmail.com Committed: 290f786b82158e7c087b81946727606cd3424e94

Patch Set 1 #

Patch Set 2 : Updated tools/Makefile.am #

Patch Set 3 : Fixed a typo #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -71 lines)			Patch
M	po/POTFILES.in	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/Makefile.am	View	1 2	1 chunk	+2 lines, -17 lines	0 comments	Download
M	ui/gtk3/Makefile.am	View		8 chunks	+32 lines, -40 lines	0 comments	Download
M	ui/gtk3/emojierapp.vala	View		3 chunks	+19 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 7 months ago (2017-04-17 07:00:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
290f786b82158e7c087b81946727606cd3424e94 (presubmit successful).

Expand All Messages | Collapse All Messages