Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(359)

Issue 312610043: ui/gtk3: Fix build failures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by fujiwara
Modified:
6 years, 11 months ago
Reviewers:
shawn.p.huang, Peng
CC:
Peng Wu
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Fix build failures ibus-ui-emoijer needs to be built at last in ui/gtk3 Also fixed po/POTFILES.in for `make dist` Now I moved libibusemojidialog.so and IBusEmojiDialog-1.0.[gir|typelib] and ibus-emoji-dialog-1.0.vapi to noinst because now ibus-ui-emojier is available and they are private libraries. R=Shawn.P.Huang@gmail.com Committed: 290f786b82158e7c087b81946727606cd3424e94

Patch Set 1 #

Patch Set 2 : Updated tools/Makefile.am #

Patch Set 3 : Fixed a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -71 lines) Patch
M po/POTFILES.in View 1 chunk +1 line, -0 lines 0 comments Download
M tools/Makefile.am View 1 2 1 chunk +2 lines, -17 lines 0 comments Download
M ui/gtk3/Makefile.am View 8 chunks +32 lines, -40 lines 0 comments Download
M ui/gtk3/emojierapp.vala View 3 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 11 months ago (2017-04-13 11:16:07 UTC) #1
Peng
On 2017/04/13 11:16:07, fujiwara wrote: lgtm
6 years, 11 months ago (2017-04-15 00:57:12 UTC) #2
fujiwara
6 years, 11 months ago (2017-04-17 07:00:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
290f786b82158e7c087b81946727606cd3424e94 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b