Issue 312600043: [plaso] Catch worker process monitoring exceptions #1203

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 312600043: [plaso] Catch worker process monitoring exceptions #1203 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years ago by Joachim Metz

Modified:
6 years, 11 months ago

Reviewers:
jberggren, romaing, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Catch worker process monitoring exceptions #1203

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -3 lines)			Patch
M	plaso/multi_processing/engine.py	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	plaso/multi_processing/psort.py	View	1 chunk	+7 lines, -1 line	2 comments	Download
M	plaso/multi_processing/task_engine.py	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/312600043/diff/1/plaso/multi_processing/psort.py File plaso/multi_processing/psort.py (right): https://codereview.appspot.com/312600043/diff/1/plaso/multi_processing/psort.py#newcode389 plaso/multi_processing/psort.py:389: self._RegisterProcess(process) You might want to catch this too, as ...

7 years ago (2017-04-09 18:39:29 UTC) #2

Joachim Metz

7 years ago (2017-04-10 03:54:59 UTC) #3

onager

On 2017/04/10 03:54:59, Joachim Metz wrote: > https://codereview.appspot.com/312600043/diff/1/plaso/multi_processing/psort.py > File plaso/multi_processing/psort.py (right): > > https://codereview.appspot.com/312600043/diff/1/plaso/multi_processing/psort.py#newcode389 ...

6 years, 11 months ago (2017-05-15 10:56:39 UTC) #4

Joachim Metz

6 years, 11 months ago (2017-05-15 19:24:06 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix1203

Expand All Messages | Collapse All Messages