Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6607)

Issue 312360043: TBR: i#1273 use drmgr everywhere: update modxfer* to use drmgr

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by bruening
Modified:
7 years, 2 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1273 use drmgr everywhere: update modxfer* to use drmgr Updates the modxfer and modxfer_app2lib samples to use drmgr's analysis and insertion events. This also requires using drreg for modxfer due to its use of drx_insert_counter_update(). Of note is that we have to restore app values prior to dr_insert_mbr_instrumentation(). This hit a bug where drreg_restore_app_values() doesn't skip segment regs, which we also fix here. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -74 lines) Patch
M api/samples/CMakeLists.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M api/samples/modxfer.c View 6 chunks +69 lines, -42 lines 0 comments Download
M api/samples/modxfer_app2lib.c View 5 chunks +49 lines, -29 lines 0 comments Download
M ext/drreg/drreg.c View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2
bruening
7 years, 2 months ago (2017-01-30 06:24:07 UTC) #1
bruening
7 years, 2 months ago (2017-01-30 06:24:09 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/4891c7257d16e5e0e918b0918b1bdb2...

Final commit log: 
---------------
i#1273 use drmgr everywhere: update modxfer* to use drmgr

Updates the modxfer and modxfer_app2lib samples to use drmgr's analysis and
insertion events.  This also requires using drreg for modxfer due to its
use of drx_insert_counter_update().

Of note is that we have to restore app values prior to
dr_insert_mbr_instrumentation().  This hit a bug where
drreg_restore_app_values() doesn't skip segment regs, which we also fix
here.

Review-URL: https://codereview.appspot.com/312360043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b