Issue 311990043: [dftimewolf] Misc fixes, cleanups, docstring updates.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 311990043: [dftimewolf] Misc fixes, cleanups, docstring updates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by onager

Modified:
7 years, 6 months ago

Reviewers:
jberggren, onager, someguyiknow, romaing

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dftimewolf] Misc fixes, cleanups, docstring updates.

Patch Set 1 #

Patch Set 2 : Misc fixes, cleanups, docstring updates. #

Patch Set 3 : Misc fixes, cleanups, docstring updates. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -166 lines)			Patch
M	dftimewolf/__init__.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dftimewolf/lib/__init__.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dftimewolf/lib/collectors.py	View	1 2	18 chunks	+193 lines, -107 lines	0 comments	Download
M	dftimewolf/lib/processors.py	View	1 2	4 chunks	+30 lines, -14 lines	0 comments	Download
M	dftimewolf/lib/timesketch_utils.py	View		10 chunks	+27 lines, -21 lines	0 comments	Download
M	dftimewolf/lib/utils.py	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	dftimewolf/timewolf_cli.py	View	1	8 chunks	+13 lines, -10 lines	0 comments	Download
M	dftimewolf/timewolf_collect.py	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	dftimewolf/timewolf_export.py	View	1	4 chunks	+5 lines, -3 lines	0 comments	Download
M	dftimewolf/timewolf_process.py	View		2 chunks	+3 lines, -1 line	0 comments	Download
A	requirements.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	utils/upload.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

onager

On 2016/10/20 14:09:16, onager wrote: Not yet ready for review.

7 years, 6 months ago (2016-10-20 14:10:19 UTC) #2

jberggren

On 2016/10/20 15:52:07, onager wrote: > Code updated. LGTM

7 years, 6 months ago (2016-10-20 16:12:55 UTC) #5

onager

7 years, 6 months ago (2016-10-21 12:49:15 UTC) #6

On 2016/10/20 16:12:55, jberggren wrote:
> On 2016/10/20 15:52:07, onager wrote:
> > Code updated.
> 
> LGTM

This was committed manually by someguyiknow as
https://github.com/log2timeline/dftimewolf/pull/5

Expand All Messages | Collapse All Messages