i#2006 generalize drcachesime: add drx API supporting custom file ops functions

Commit log for first patchset:
---------------
i#2006 generalize drcachesime: add drx API supporting custom file ops functions

Adds drx_open_unique_file_ex, drx_open_unique_appid_file_ex,
and drx_opnd_unique_appid_dir_ex to open file/dir using provided
file operation functions.
---------------

[bruening, 2016-10-19 21:34:46]

"drcachesime"?

https://codereview.appspot.com/311960043/diff/1/ext/drx/drx.h
File ext/drx/drx.h (right):

https://codereview.appspot.com/311960043/diff/1/ext/drx/drx.h#newcode241
ext/drx/drx.h:241: * Uses the provided function \p open_file_func to open a new
file
It seems like it would be more flexible to just create the path string, and let
the caller do with what he/she wants, rather than passing in a file open
signature that has to take a certain shape and take in the same flags as DR's. 
In fact, maybe we don't even need a new function for this: some additional
extra_flags flag could say not to actually open the file?

https://codereview.appspot.com/311960043/diff/1/ext/drx/drx.h#newcode246
ext/drx/drx.h:246: * Passes \p extra_flags through to the dr_open_file() call.
wrong function

[zhaoqin, 2016-10-20 01:08:03]

https://codereview.appspot.com/311960043/diff/1/ext/drx/drx.h
File ext/drx/drx.h (right):

https://codereview.appspot.com/311960043/diff/1/ext/drx/drx.h#newcode241
ext/drx/drx.h:241: * Uses the provided function \p open_file_func to open a new
file
On 2016/10/19 21:34:46, bruening wrote:
> It seems like it would be more flexible to just create the path string, and
let
> the caller do with what he/she wants, rather than passing in a file open
> signature that has to take a certain shape and take in the same flags as DR's.

> In fact, maybe we don't even need a new function for this: some additional
> extra_flags flag could say not to actually open the file?

xref https://github.com/DynamoRIO/dynamorio/blob/master/ext/drx/drx.c#L1316
It need repeatedly try to open the file to make sure create the unique file.

[zhaoqin, 2016-10-21 20:19:57]

Commit log for latest patchset:
---------------
i#2006 generalize drcachesim: add DRX_FILE_SKIP_OPEN for skip file open

Adds DRX_FILE_SKIP_OPEN so that drx_open_unique_file/drx_open_unique_appid_file
can skip the file open and return the resulting file name string only.

Adds test for using DRX_FILE_SKIP_OPEN.

Review-URL: https://codereview.appspot.com/311960043
---------------

[zhaoqin, 2016-10-21 20:24:48]

Commit log for latest patchset:
---------------
i#2006 generalize drcachesim: add DRX_FILE_SKIP_OPEN for skip file open

Adds DRX_FILE_SKIP_OPEN so that drx_open_unique_file/drx_open_unique_appid_file
can skip the file open and return the resulting file name string only.

Adds test for using DRX_FILE_SKIP_OPEN.

Review-URL: https://codereview.appspot.com/311960043
---------------

[zhaoqin, 2016-10-21 20:27:43]

Commit log for latest patchset:
---------------
i#2006 generalize drcachesim: add DRX_FILE_SKIP_OPEN for skip file open

Adds DRX_FILE_SKIP_OPEN so that drx_open_unique_file/drx_open_unique_appid_file
can skip the file open and return the resulting file name string only.

Adds test for using DRX_FILE_SKIP_OPEN.

Review-URL: https://codereview.appspot.com/311960043
---------------

[zhaoqin, 2016-10-21 20:42:45]

Commit log for latest patchset:
---------------
i#2006 generalize drcachesim: add DRX_FILE_SKIP_OPEN for skip file open

Adds DRX_FILE_SKIP_OPEN so that drx_open_unique_file/drx_open_unique_appid_file
can skip the file open and return the resulting file name string only.

Adds test for using DRX_FILE_SKIP_OPEN.

Review-URL: https://codereview.appspot.com/311960043
---------------

[bruening, 2016-10-21 22:13:36]

LGTM if this is sufficient

https://codereview.appspot.com/311960043/diff/80001/ext/drx/drx.h
File ext/drx/drx.h (right):

https://codereview.appspot.com/311960043/diff/80001/ext/drx/drx.h#newcode245
ext/drx/drx.h:245: * Unique name is not guaranteed and xxxx is set to 0000.
Hmm, right, so that's the problem with this approach: not guaranteed unique.  Is
this sufficient for your use cases?  What about multi-process apps -- they'll
collide?

[zhaoqin, 2016-10-23 02:33:59]

https://codereview.appspot.com/311960043/diff/80001/ext/drx/drx.h
File ext/drx/drx.h (right):

https://codereview.appspot.com/311960043/diff/80001/ext/drx/drx.h#newcode245
ext/drx/drx.h:245: * Unique name is not guaranteed and xxxx is set to 0000.
On 2016/10/21 22:13:36, bruening wrote:
> Hmm, right, so that's the problem with this approach: not guaranteed unique. 
Is
> this sufficient for your use cases?  What about multi-process apps -- they'll
> collide?

set it to random number using dr_get_random_value().

[zhaoqin, 2016-10-23 02:34:11]

Commit log for latest patchset:
---------------
i#2006 generalize drcachesim: add DRX_FILE_SKIP_OPEN for skip file open

Adds DRX_FILE_SKIP_OPEN so that drx_open_unique_file/drx_open_unique_appid_file
can skip the file open and return the resulting file name string only.

Adds test for using DRX_FILE_SKIP_OPEN.

Review-URL: https://codereview.appspot.com/311960043
---------------

[zhaoqin, 2016-10-23 02:39:48]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/dc73844794e22d832e4bb004636824c...

Final commit log: 
---------------
i#2006 generalize drcachesim: add DRX_FILE_SKIP_OPEN for skip file open

Adds DRX_FILE_SKIP_OPEN so that drx_open_unique_file/drx_open_unique_appid_file
can skip the file open and return the resulting file name string only.

Adds test for using DRX_FILE_SKIP_OPEN.

Review-URL: https://codereview.appspot.com/311960043
---------------

[bruening, 2016-10-23 02:46:10]

If you could fix the title of this page -- all these emails with the
misspelling...