Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(965)

Issue 311670043: ICU ticket #12410: CaseMap with Edits (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by markus.icu
Modified:
4 months ago
Reviewers:
andy.heninger, roozbeh, yoshito_umaoka, yoshito, drott, J Shin
Base URL:
http://source.icu-project.org/repos/icu/branches/markus/caseix/
Visibility:
Public.

Description

C++ UTF-16 & Java

Patch Set 1 #

Total comments: 1

Patch Set 2 : C++ foldCase()->fold(), UTF-8 new-file properties #

Total comments: 24

Patch Set 3 : changes for review feedback #

Patch Set 4 : changes for review feedback (for real now) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4581 lines, -2114 lines) Patch
M icu4c/source/common/Makefile.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/common/charstr.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/common/common.vcxproj View 1 2 3 4 chunks +30 lines, -0 lines 0 comments Download
M icu4c/source/common/common.vcxproj.filters View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
A icu4c/source/common/edits.cpp View 1 2 3 1 chunk +348 lines, -0 lines 0 comments Download
M icu4c/source/common/locdspnm.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/common/locid.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/common/loclikely.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/common/ucase.h View 1 2 3 9 chunks +22 lines, -35 lines 0 comments Download
M icu4c/source/common/ucase.cpp View 1 2 3 40 chunks +205 lines, -161 lines 0 comments Download
M icu4c/source/common/ucasemap.cpp View 1 2 3 29 chunks +84 lines, -91 lines 0 comments Download
A icu4c/source/common/ucasemap_imp.h View 1 2 3 1 chunk +238 lines, -0 lines 0 comments Download
M icu4c/source/common/ucasemap_titlecase_brkiter.cpp View 1 2 3 2 chunks +21 lines, -17 lines 0 comments Download
M icu4c/source/common/ucnv_ext.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A icu4c/source/common/unicode/casemap.h View 1 2 3 1 chunk +199 lines, -0 lines 0 comments Download
A icu4c/source/common/unicode/edits.h View 1 2 3 1 chunk +247 lines, -0 lines 0 comments Download
M icu4c/source/common/unicode/locid.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M icu4c/source/common/unicode/ucasemap.h View 1 2 3 4 chunks +12 lines, -3 lines 0 comments Download
M icu4c/source/common/unicode/uenum.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M icu4c/source/common/unicode/unistr.h View 1 2 3 3 chunks +22 lines, -15 lines 0 comments Download
M icu4c/source/common/uniset_closure.cpp View 1 2 3 4 chunks +6 lines, -8 lines 0 comments Download
M icu4c/source/common/uniset_props.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M icu4c/source/common/unistr_case.cpp View 1 2 3 5 chunks +85 lines, -37 lines 0 comments Download
M icu4c/source/common/unistr_case_locale.cpp View 1 2 3 2 chunks +10 lines, -26 lines 0 comments Download
M icu4c/source/common/unistr_titlecase_brkiter.cpp View 1 2 3 3 chunks +5 lines, -34 lines 0 comments Download
M icu4c/source/common/unormcmp.cpp View 1 2 3 4 chunks +2 lines, -8 lines 0 comments Download
M icu4c/source/common/uprops.cpp View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M icu4c/source/common/ustr_imp.h View 1 2 3 2 chunks +0 lines, -222 lines 0 comments Download
M icu4c/source/common/ustr_titlecase_brkiter.cpp View 1 2 3 2 chunks +55 lines, -34 lines 0 comments Download
M icu4c/source/common/ustrcase.cpp View 1 2 3 27 chunks +307 lines, -195 lines 0 comments Download
M icu4c/source/common/ustrcase_locale.cpp View 1 2 3 3 chunks +44 lines, -62 lines 0 comments Download
M icu4c/source/common/ustring.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/affixpatternparser.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M icu4c/source/i18n/casetrn.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M icu4c/source/i18n/casetrn.cpp View 1 2 3 5 chunks +3 lines, -5 lines 0 comments Download
M icu4c/source/i18n/currpinf.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/decimfmt.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/measfmt.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/plurrule_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/rbnf.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/regeximp.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M icu4c/source/i18n/regeximp.cpp View 1 2 3 4 chunks +4 lines, -6 lines 0 comments Download
M icu4c/source/i18n/reldatefmt.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/reldtfmt.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/smpdtfmt.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M icu4c/source/i18n/titletrn.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M icu4c/source/i18n/tzfmt.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M icu4c/source/i18n/tzgnames.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/tznames_impl.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/unicode/alphaindex.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/unicode/coleitr.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/unicode/dcfmtsym.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/unicode/reldatefmt.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/zonemeta.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/test/cintltst/cstrcase.c View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M icu4c/source/test/cintltst/cucdtst.c View 1 2 3 4 chunks +1 line, -44 lines 0 comments Download
M icu4c/source/test/intltest/apicoll.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/locnmtst.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/measfmttest.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/numfmtst.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/strcase.cpp View 1 2 3 4 chunks +258 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/tmsgfmt.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/tzrulets.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/ustrtest.h View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
M icu4c/source/test/intltest/ustrtest.cpp View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M icu4c/source/tools/gendict/gendict.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D icu4j/main/classes/core/src/com/ibm/icu/impl/CaseMap.java View 1 2 3 1 chunk +0 lines, -758 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/CaseMapImpl.java View 1 2 3 1 chunk +1002 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/UCaseProps.java View 1 2 3 36 chunks +143 lines, -116 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/lang/UCharacter.java View 1 2 3 13 chunks +118 lines, -170 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/text/CaseMap.java View 1 2 3 1 chunk +341 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/text/Edits.java View 1 2 3 1 chunk +496 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/UnicodeSet.java View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M icu4j/main/classes/translit/src/com/ibm/icu/text/LowercaseTransliterator.java View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M icu4j/main/classes/translit/src/com/ibm/icu/text/TitlecaseTransliterator.java View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M icu4j/main/classes/translit/src/com/ibm/icu/text/UppercaseTransliterator.java View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/lang/UCharacterCaseTest.java View 1 2 3 3 chunks +188 lines, -1 line 0 comments Download

Messages

Total messages: 12
markus.icu
4 months, 1 week ago (2017-02-14 00:44:12 UTC) #1
markus.icu
Yoshito: Could you do the whole review? Or do you want Andy to take the ...
4 months, 1 week ago (2017-02-14 00:50:52 UTC) #2
yoshito
On 2017/02/14 00:50:52, markus.icu wrote: > Yoshito: Could you do the whole review? Or do ...
4 months, 1 week ago (2017-02-14 23:14:12 UTC) #3
markus.icu
On 2017/02/14 23:14:12, yoshito wrote: > On 2017/02/14 00:50:52, markus.icu wrote: > https://codereview.appspot.com/311670043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/text/CaseMap.java#newcode61 > > ...
4 months, 1 week ago (2017-02-15 00:37:58 UTC) #4
markus.icu
FYI In Java, I renamed impl/CaseMap.java to impl/CaseMapImpl.java to avoid collision with new text/CaseMap.java. Rietveld ...
4 months, 1 week ago (2017-02-15 00:47:38 UTC) #5
markus.icu
C++ foldCase()->fold(), UTF-8 new-file properties
4 months, 1 week ago (2017-02-15 22:53:08 UTC) #6
yoshito
I finished reviewing the Java implementation. The code looks pretty clean and I think Java ...
4 months, 1 week ago (2017-02-16 14:51:16 UTC) #7
andy.heninger
https://codereview.appspot.com/311670043/diff/20001/icu4c/source/common/edits.cpp File icu4c/source/common/edits.cpp (right): https://codereview.appspot.com/311670043/diff/20001/icu4c/source/common/edits.cpp#newcode145 icu4c/source/common/edits.cpp:145: UBool Edits::growArray() { Too bad you can't use MaybeStackArray. ...
4 months, 1 week ago (2017-02-17 05:59:54 UTC) #8
markus.icu
https://codereview.appspot.com/311670043/diff/20001/icu4c/source/common/edits.cpp File icu4c/source/common/edits.cpp (right): https://codereview.appspot.com/311670043/diff/20001/icu4c/source/common/edits.cpp#newcode145 icu4c/source/common/edits.cpp:145: UBool Edits::growArray() { On 2017/02/17 05:59:53, andy.heninger wrote: > ...
4 months ago (2017-02-17 18:31:22 UTC) #9
markus.icu
changes for review feedback
4 months ago (2017-02-17 18:43:57 UTC) #10
markus.icu
changes for review feedback (for real now)
4 months ago (2017-02-17 18:56:40 UTC) #11
andy.heninger
4 months ago (2017-02-17 19:10:43 UTC) #12
On 2017/02/17 18:56:40, markus.icu wrote:
> changes for review feedback (for real now)

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted