Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7174)

Issue 311520043: TBR: i#1795 drreg: move xl8 slowpath clearing to inlined instru

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by bruening
Modified:
7 years, 3 months ago
Reviewers:
zhaoqin
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1795 drreg: move xl8 slowpath clearing to inlined instru Moves the clearing of translation address sharing when the slowpath is entered (due to clobbering the register) from C code, where we need to know the TLS slot (which is not drreg-friendly) and we need a 2-step return path, to the inlined instrumentation at the return-from-slowpath point. This increases the code cache size slightly but should enable removal of the 2-step return and makes moving to drreg easier. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -51 lines) Patch
M drmemory/fastpath.c View 4 chunks +11 lines, -36 lines 0 comments Download
M drmemory/fastpath_x86.c View 6 chunks +12 lines, -14 lines 0 comments Download
M drmemory/slowpath.c View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 2
bruening
7 years, 3 months ago (2017-01-13 05:23:20 UTC) #1
bruening
7 years, 3 months ago (2017-01-13 05:23:21 UTC) #2
Committed as
https://github.com/DynamoRIO/drmemory/commit/31250dfb76127ac96070fe2def38309f...

Final commit log: 
---------------
i#1795 drreg: move xl8 slowpath clearing to inlined instru

Moves the clearing of translation address sharing when the slowpath is
entered (due to clobbering the register) from C code, where we need to
know the TLS slot (which is not drreg-friendly) and we need a 2-step return
path, to the inlined instrumentation at the return-from-slowpath point.
This increases the code cache size slightly but should enable removal of
the 2-step return and makes moving to drreg easier.

Review-URL: https://codereview.appspot.com/311520043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b