Issue 311480043: i#2050: Fixes 32-bit compilation, Ubuntu 16.04

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 311480043: i#2050: Fixes 32-bit compilation, Ubuntu 16.04

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by toshi

Modified:
7 years, 3 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2050: Fixes 32-bit compilation, Ubuntu 16.04 Affects Ubuntu 16.04, gcc version 5.4.0. When trying to access a label in DR_ANNOTATION_ATTRIBUTES, we dereference some offset from the GOT. However, in 32-bit mode the linker chokes because it is not given the base register for the GOT. We specify the base register for 32-bit code only. Fixes #2050 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	core/lib/dr_annotations_asm.h	View		4 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

toshi

7 years, 3 months ago (2017-01-04 18:24:43 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/24c4f7ca3caca4a406c284759f1bcbf...

Final commit log: 
---------------
i#2050: Fixes 32-bit compilation, Ubuntu 16.04

Affects Ubuntu 16.04, gcc version 5.4.0. When trying to access a label in
DR_ANNOTATION_ATTRIBUTES, we dereference some offset from the GOT. However, in
32-bit mode the linker chokes because it is not given the base register for
the GOT. We specify the base register for 32-bit code only.

Fixes #2050

Review-URL: https://codereview.appspot.com/311480043
---------------

Expand All Messages | Collapse All Messages