Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1797)

Issue 311430043: add choral and choral-cautionary accidental style (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by akobel
Modified:
2 years, 6 months ago
Reviewers:
pkx166h, Graham Percival, thomasmorley651, a-kobel
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add choral and choral-cautionary accidental style This solves the issues mentioned in https://lists.gnu.org/archive/html/lilypond-user/2016-12/msg00201.html that accidental style could not apply to ChoirStaves in the same way as they did for PianoStaves, StaffGroups or GrandStaves. No impact on existing functionality, but now ChoirStaves are equal siblings w.r.t. accidental styles. In addition, a reasonable mix of the modern-voice and piano cautionary style is defined, which caters to both all-observant and egocentric readers.

Patch Set 1 #

Total comments: 2

Patch Set 2 : update documentation for choral accidental style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -1 line) Patch
M Documentation/changes.tely View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 2 chunks +124 lines, -1 line 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M scm/music-functions.scm View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7
akobel
add choral and choral-cautionary accidental style This solves the issues mentioned in https://lists.gnu.org/archive/html/lilypond-user/2016-12/msg00201.html that accidental ...
2 years, 6 months ago (2016-12-13 20:10:26 UTC) #1
pkx166h
Passes make, make check and a full make doc
2 years, 6 months ago (2016-12-14 13:26:32 UTC) #2
thomasmorley651
Worth an entry in changes? Some wording-nitpicks, otherwise LGTM https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely#newcode2210 Documentation/notation/pitches.itely:2210: ...
2 years, 6 months ago (2016-12-14 22:13:11 UTC) #3
a-kobel_a-kobel.de
On 2016-12-14 23:13, thomasmorley65@gmail.com wrote: > Worth an entry in changes? Maybe. Doesn't need a ...
2 years, 6 months ago (2016-12-15 00:09:12 UTC) #4
akobel
update documentation for choral accidental style
2 years, 6 months ago (2016-12-18 22:10:48 UTC) #5
akobel
New patch set is online that includes an entry in changes.tely and changes the wording ...
2 years, 6 months ago (2016-12-19 09:44:35 UTC) #6
Graham Percival
2 years, 6 months ago (2016-12-22 22:31:59 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b