add choral and choral-cautionary accidental style

add choral and choral-cautionary accidental style

This solves the issues mentioned in
  https://lists.gnu.org/archive/html/lilypond-user/2016-12/msg00201.html
that accidental style could not apply to ChoirStaves in the same way
as they did for PianoStaves, StaffGroups or GrandStaves.
No impact on existing functionality, but now ChoirStaves are equal
siblings w.r.t. accidental styles.

In addition, a reasonable mix of the modern-voice and piano cautionary
style is defined, which caters to both all-observant and egocentric
readers.

[akobel, 2016-12-13 20:10:26]

add choral and choral-cautionary accidental style

This solves the issues mentioned in
  https://lists.gnu.org/archive/html/lilypond-user/2016-12/msg00201.html
that accidental style could not apply to ChoirStaves in the same way as they did
for PianoStaves, StaffGroups or GrandStaves. No impact on existing
functionality, but now ChoirStaves are equal siblings w.r.t. accidental styles.

In addition, a reasonable mix of the modern-voice and piano cautionary style is
defined, which caters to both all-observant and egocentric readers.

[pkx166h, 2016-12-14 13:26:32]

Passes make, make check and a full make doc

[thomasmorley651, 2016-12-14 22:13:11]

Worth an entry in changes?

Some wording-nitpicks, otherwise
LGTM

https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitche...
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitche...
Documentation/notation/pitches.itely:2210: style. It is intended for editions
that are used both by singers that only
The wording feels not very elegant.
Though, I'm a non-native speaker...

https://codereview.appspot.com/311430043/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):

https://codereview.appspot.com/311430043/diff/1/scm/music-functions.scm#newco...
scm/music-functions.scm:1847: ;; that the first alteration within a voice (as
opposed to on the
wording again, maybe:
Similar to piano, except that the first alteration within a voice is always
printed (as opposed to within a staff).
But again: non-native-speaker

[a-kobel_a-kobel.de, 2016-12-15 00:09:12]

On 2016-12-14 23:13, thomasmorley65@gmail.com wrote:
> Worth an entry in changes?

Maybe. Doesn't need a lot, I guess; something like
"Accidental rules can now be defined across ChoirStaff contexts. Two new 
rules choral and choral-cautionary are available that combine the 
characteristics of modern-voice and piano or their equivalents with 
cautionary accidentals."

> Some wording-nitpicks, otherwise
> LGTM

Thanks.

>
https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitche...
>
> Documentation/notation/pitches.itely:2210: style. It is intended for
> editions that are used both by singers that only
> The wording feels not very elegant.
> Though, I'm a non-native speaker...

Not a native speaker here, either, so I'm open to proposals.

>
https://codereview.appspot.com/311430043/diff/1/scm/music-functions.scm#newco...
>
> scm/music-functions.scm:1847: ;; that the first alteration within a
> voice (as opposed to on the
> wording again, maybe:
> Similar to piano, except that the first alteration within a voice is
> always printed (as opposed to within a staff).

Agreed, that sounds better.


Cheers,
Alexander

[akobel, 2016-12-18 22:10:48]

update documentation for choral accidental style

[akobel, 2016-12-19 09:44:35]

New patch set is online that includes an entry in changes.tely and changes the
wording of the two places in question.


Cheers,
Alexander

[Graham Percival, 2016-12-22 22:31:59]

LGTM