Issue 311220043: TBR: i#2049 burst_threads crash: add DR_CLEANCALL_ALWAYS_OUT_OF_LINE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 311220043: TBR: i#2049 burst_threads crash: add DR_CLEANCALL_ALWAYS_OUT_OF_LINE

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by bruening

Modified:
7 years, 5 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2049 burst_threads crash: add DR_CLEANCALL_ALWAYS_OUT_OF_LINE Adds a new flag DR_CLEANCALL_ALWAYS_OUT_OF_LINE and uses it to ensure the jecxz in drmemtrace can always skip its clean call. Fixes #2049 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -11 lines)			Patch
M	api/docs/release.dox	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	clients/drcachesim/tracer/tracer.cpp	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	core/arch/aarch64/clean_call_opt.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/arch/arch.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/arch/arm/clean_call_opt.c	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	core/arch/x86/clean_call_opt.c	View	3 chunks	+12 lines, -5 lines	0 comments	Download
M	core/lib/instrument.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	core/lib/instrument_api.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 5 months ago (2016-11-01 04:08:39 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/2c6ae55eab665aad7b68cbf23376a1b...

Final commit log: 
---------------
i#2049 burst_threads crash: add DR_CLEANCALL_ALWAYS_OUT_OF_LINE

Adds a new flag DR_CLEANCALL_ALWAYS_OUT_OF_LINE and uses it to ensure the
jecxz in drmemtrace can always skip its clean call.

Fixes #2049

Review-URL: https://codereview.appspot.com/311220043
---------------

Expand All Messages | Collapse All Messages