Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(435)

Issue 31020043: Add authentication token handler class

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by gary.poster
Modified:
10 years, 4 months ago
Reviewers:
frankban, mp+196347
Visibility:
Public.

Description

Add authentication token handler class This is the first branch in a set of what will likely be three. This one simply creates the handler that we will use. There's no QA yet. https://code.launchpad.net/~gary/charms/precise/juju-gui/authtoken1/+merge/196347 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add authentication token handler class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M server/guiserver/auth.py View 1 3 chunks +143 lines, -4 lines 0 comments Download
M server/guiserver/tests/test_auth.py View 1 2 chunks +163 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
10 years, 4 months ago (2013-11-22 18:09:09 UTC) #1
frankban
Nice branch Gary. Tests pass and are very nice. LGTM with only minors/optional changes. Thank ...
10 years, 4 months ago (2013-11-22 19:04:29 UTC) #2
gary.poster
*** Submitted: Add authentication token handler class This is the first branch in a set ...
10 years, 4 months ago (2013-11-23 02:12:46 UTC) #3
gary.poster
10 years, 4 months ago (2013-11-23 02:23:31 UTC) #4
Thank you for the very helpful review, Francesco, and for the elegant pre-imp
ideas that guided this branch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b