Issue 310160043: TBR: i#95 Linux detach, i#1512 startstop flaky: rewrite api.startstop test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 310160043: TBR: i#95 Linux detach, i#1512 startstop flaky: rewrite api.startstop test

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by bruening

Modified:
7 years, 8 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#95 Linux detach, i#1512 startstop flaky: rewrite api.startstop test Rewrites the api.startstop test to use condition variables for more reliable and extensive testing of native<->DR transitions. Adds condition variable support for Linux and Windows to the tests. Removes the FLAKY marker from the test. Fixes #1512 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+310 lines, -65 lines)			Patch
M	suite/tests/CMakeLists.txt	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	suite/tests/api/startstop.c	View	6 chunks	+139 lines, -61 lines	0 comments	Download
M	suite/tests/api/startstop.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
A	suite/tests/condvar.h	View	1 chunk	+168 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 8 months ago (2016-09-08 03:26:11 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/ba6e2e6715787127826f2cefcfea03f...

Final commit log: 
---------------
i#95 Linux detach, i#1512 startstop flaky: rewrite api.startstop test

Rewrites the api.startstop test to use condition variables for more
reliable and extensive testing of native<->DR transitions.  Adds condition
variable support for Linux and Windows to the tests.  Removes the FLAKY
marker from the test.

Fixes #1512

Review-URL: https://codereview.appspot.com/310160043
---------------

Expand All Messages | Collapse All Messages