Issue 31000043: Include pip dependency instead of using system's

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 31000043: Include pip dependency instead of using system's

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by benji

Modified:
10 years, 5 months ago

Reviewers:
frankban, mp+196328

Visibility:
Public.

Description

Include pip dependency instead of using system's I also killed an entire village of ./ https://code.launchpad.net/~benji/charms/precise/juju-gui/use-known-pip/+merge/196328 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Include pip dependency instead of using system's #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	Makefile	View	4 chunks	+10 lines, -8 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/00-setup	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benji

Here are some pre-review comments. https://codereview.appspot.com/31000043/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/31000043/diff/1/Makefile#newcode20 Makefile:20: rsync xvfb We're using ...

10 years, 5 months ago (2013-11-22 17:33:22 UTC) #2

frankban

I successfully created the testing environment with this branch. LGTM thank you! https://codereview.appspot.com/31000043/diff/1/Makefile File Makefile ...

10 years, 5 months ago (2013-11-22 17:49:29 UTC) #3

benji

10 years, 5 months ago (2013-11-22 18:43:00 UTC) #4

*** Submitted:

Include pip dependency instead of using system's

I also killed an entire village of ./

R=frankban
CC=
https://codereview.appspot.com/31000043

Expand All Messages | Collapse All Messages