Issue 309960043: [plaso] Updated review script.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 309960043: [plaso] Updated review script. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by Joachim Metz

Modified:
7 years, 6 months ago

Reviewers:
jberggren, romaing, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

[plaso] Updated review script.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+357 lines, -221 lines)			Patch
	M	utils/review.py	View		78 chunks	+357 lines, -221 lines	0 comments	Download

Total messages: 4

onager

On 2016/09/24 14:33:34, Joachim Metz wrote: > Code updated. LGTM

7 years, 6 months ago (2016-10-11 10:14:51 UTC) #3

Joachim Metz

7 years, 6 months ago (2016-10-11 19:47:25 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close review