Issue 30980044: No-op integration of AuthenticationTokenHandler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30980044: No-op integration of AuthenticationTokenHandler

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by gary.poster

Modified:
10 years, 5 months ago

Reviewers:
frankban, mp+196351

Visibility:
Public.

Description

No-op integration of AuthenticationTokenHandler This branch simply hooks up the AuthenticationTokenHandler everywhere it needs to be. It isn't actually utilized yet. https://code.launchpad.net/~gary/charms/precise/juju-gui/authtoken2/+merge/196351 Requires: https://code.launchpad.net/~gary/charms/precise/juju-gui/authtoken1/+merge/196347 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : No-op integration of AuthenticationTokenHandler #

Patch Set 3 : No-op integration of AuthenticationTokenHandler #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -9 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	server/guiserver/apps.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	server/guiserver/auth.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	server/guiserver/handlers.py	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	server/guiserver/tests/test_apps.py	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	server/guiserver/tests/test_auth.py	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	server/guiserver/tests/test_handlers.py	View		5 chunks	+9 lines, -3 lines	0 comments	Download
M	server/guiserver/tests/test_utils.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

*** Submitted: No-op integration of AuthenticationTokenHandler This branch simply hooks up the AuthenticationTokenHandler everywhere it ...

10 years, 5 months ago (2013-11-25 13:14:53 UTC) #4

gary.poster

10 years, 5 months ago (2013-11-25 13:17:36 UTC) #5

On 2013/11/25 11:39:48, frankban wrote:
> LGTM thank you!

Thank you for the review, Francesco.

Expand All Messages | Collapse All Messages