Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 309260043: TBR: i#975 static DR: refactor STATIC_LIBRARY to a side-by-side target

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by bruening
Modified:
9 years, 9 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#975 static DR: refactor STATIC_LIBRARY to a side-by-side target This is a big refactoring of the STATIC_LIBRARY top-level CMake configuration and separate build into instead using a side-by-side dynamorio_static target. Removes STATIC_LIBRARY from all CMake code. It is no longer a separate build choice. Adds a dynamorio_static static library build of DR that is always built. Disables data section protection for dynamorio_static. Adds a -static option to drrun to set the env var for auto-takeover of an app using dynamorio_static. Adds a new CMake utility configure_DynamoRIO_static() to make it easy to link an app with dynamorio_static. Renames the existing static_* tests to drdecode_* to make it clear what they are testing. Adds a new test static_explicit.c to test explicit use of the start/stop API with dynamorio_static. DR still does not look for clients without runtime options being set: that will be added in future work. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -708 lines) Patch
M CMakeLists.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M api/docs/release.dox View 1 chunk +4 lines, -1 line 0 comments Download
M api/samples/CMakeLists.txt View 2 chunks +1 line, -7 lines 0 comments Download
M clients/drcov/CMakeLists.txt View 1 chunk +1 line, -7 lines 0 comments Download
M core/CMakeLists.txt View 12 chunks +296 lines, -257 lines 0 comments Download
M core/lib/globals_shared.h View 1 chunk +6 lines, -0 lines 0 comments Download
M core/optionsx.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/unix/injector.c View 1 chunk +3 lines, -2 lines 0 comments Download
M core/win32/os.c View 4 chunks +15 lines, -0 lines 0 comments Download
M ext/CMakeLists.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M ext/drcovlib/CMakeLists.txt View 1 chunk +6 lines, -8 lines 0 comments Download
M ext/drmgr/CMakeLists.txt View 3 chunks +4 lines, -6 lines 0 comments Download
M ext/drreg/CMakeLists.txt View 2 chunks +6 lines, -8 lines 0 comments Download
M ext/drsyms/CMakeLists.txt View 5 chunks +33 lines, -47 lines 0 comments Download
M ext/drutil/CMakeLists.txt View 3 chunks +5 lines, -7 lines 0 comments Download
M ext/drwrap/CMakeLists.txt View 3 chunks +7 lines, -9 lines 0 comments Download
M ext/drx/CMakeLists.txt View 3 chunks +8 lines, -10 lines 0 comments Download
M make/DynamoRIOConfig.cmake.in View 2 chunks +32 lines, -0 lines 0 comments Download
M make/configure.cmake.h View 2 chunks +1 line, -2 lines 0 comments Download
M suite/tests/CMakeLists.txt View 20 chunks +32 lines, -63 lines 0 comments Download
A + suite/tests/api/drdecode_arm.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + suite/tests/api/drdecode_arm.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + suite/tests/api/drdecode_x86.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + suite/tests/api/drdecode_x86.template View 0 chunks +-1 lines, --1 lines 0 comments Download
D suite/tests/api/static_arm.c View 1 chunk +0 lines, -85 lines 0 comments Download
D suite/tests/api/static_arm.template View 1 chunk +0 lines, -6 lines 0 comments Download
A + suite/tests/api/static_startstop.c View 2 chunks +50 lines, -26 lines 0 comments Download
A suite/tests/api/static_startstop.expect View 1 chunk +4 lines, -0 lines 0 comments Download
D suite/tests/api/static_x86.c View 1 chunk +0 lines, -120 lines 0 comments Download
D suite/tests/api/static_x86.template View 1 chunk +0 lines, -12 lines 0 comments Download
M suite/tests/client-interface/modules.appdll.c View 2 chunks +1 line, -3 lines 0 comments Download
M tools/drdeploy.c View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 2
bruening
9 years, 9 months ago (2016-08-31 06:40:40 UTC) #1
bruening
9 years, 9 months ago (2016-08-31 06:40:43 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/8db618085fbe331f58709a6e5fade48...

Final commit log: 
---------------
i#975 static DR: refactor STATIC_LIBRARY to a side-by-side target

This is a big refactoring of the STATIC_LIBRARY top-level CMake
configuration and separate build into instead using a side-by-side
dynamorio_static target.

Removes STATIC_LIBRARY from all CMake code.  It is no longer a separate
build choice.

Adds a dynamorio_static static library build of DR that is always built.

Disables data section protection for dynamorio_static.

Adds a -static option to drrun to set the env var for auto-takeover of an
app using dynamorio_static.

Adds a new CMake utility configure_DynamoRIO_static() to make it easy to
link an app with dynamorio_static.

Renames the existing static_* tests to drdecode_* to make it clear what
they are testing.

Adds a new test static_explicit.c to test explicit use of the start/stop
API with dynamorio_static.

DR still does not look for clients without runtime options being set: that
will be added in future work.

Review-URL: https://codereview.appspot.com/309260043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b