LL: Speed up delete queries by using a builtin index (b/25088575)

Speed up delete queries by using a builtin index (b/25088575).

Add an alternative delete query that uses a predefined database index
rather than requiring the Google recommended index. The new query is
controlled by a new useIndexedDeleteQuery advanced config property.
The default is false, to avoid forcing all Oracle-based customers to
update the LAPI white list.

[JohnL, 2016-07-30 02:31:28]

Fix 80 cols

[Brett Johnson, 2016-08-01 22:45:18]

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
File
projects/otex-core/source/java/com/google/enterprise/connector/otex/SqlQueries.java
(right):

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
projects/otex-core/source/java/com/google/enterprise/connector/otex/SqlQueries.java:55:
String[] columns = resources.getStringArray(key + ".select");
Why change execute() to use the helper methods, but not executeNoThrow()?

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
projects/otex-core/source/java/com/google/enterprise/connector/otex/SqlQueries.java:94:
* incremental crawling without duplicates.
Change comment to reflect that is is only used with delete using custom index? 
Or add another trivial constant for DELETE_ORDER_BY_STANDARD?

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
File
projects/otex-core/source/javatests/com/google/enterprise/connector/otex/LivelinkTraversalManagerTest.java
(right):

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
projects/otex-core/source/javatests/com/google/enterprise/connector/otex/LivelinkTraversalManagerTest.java:857:
private void testGetDeletes(boolean useIndexedDeleteQuery ,int batchHint,
comma+space after useIndexedDeleteQuery

[JohnL, 2016-08-01 23:39:52]

Code review comments

[JohnL, 2016-08-01 23:41:25]

PTAL

John L

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
File
projects/otex-core/source/java/com/google/enterprise/connector/otex/SqlQueries.java
(right):

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
projects/otex-core/source/java/com/google/enterprise/connector/otex/SqlQueries.java:55:
String[] columns = resources.getStringArray(key + ".select");
On 2016/08/01 22:45:17, johnsonb wrote:
> Why change execute() to use the helper methods, but not executeNoThrow()?

I didn't notice. It turns out that executeNoThrow is never used. It was
introduced and then dropped in April 2013.

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
projects/otex-core/source/java/com/google/enterprise/connector/otex/SqlQueries.java:94:
* incremental crawling without duplicates.
On 2016/08/01 22:45:17, johnsonb wrote:
> Change comment to reflect that is is only used with delete using custom index?

> Or add another trivial constant for DELETE_ORDER_BY_STANDARD?

Done.

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
File
projects/otex-core/source/javatests/com/google/enterprise/connector/otex/LivelinkTraversalManagerTest.java
(right):

https://codereview.appspot.com/308860043/diff/20001/projects/otex-core/source...
projects/otex-core/source/javatests/com/google/enterprise/connector/otex/LivelinkTraversalManagerTest.java:857:
private void testGetDeletes(boolean useIndexedDeleteQuery ,int batchHint,
On 2016/08/01 22:45:18, johnsonb wrote:
> comma+space after useIndexedDeleteQuery

Done.

[Brett Johnson, 2016-08-02 00:04:48]

LGTM

[Srinivas, 2016-08-02 01:21:59]

On 2016/08/02 00:04:48, johnsonb wrote:
> LGTM

LGTM

[JohnL, 2016-08-10 23:17:10]

Committed:
https://github.com/googlegsa/livelink.v3/commit/7f0689e888abcb9a65daba94b7846...

John L