Issue 308680043: TBR: i#1921 native signals: remove handlers and hooks while fully native

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 308680043: TBR: i#1921 native signals: remove handlers and hooks while fully native

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by bruening

Modified:
10 years ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1921 native signals: remove handlers and hooks while fully native Adds removal of all signal handler and vsyscall hooks while fully native (during usage of the start/stop API). This simplifies handling of native threads. This does not yet solve single-native-thread signals for native_exec or DR_EMIT_GO_NATIVE. The implementation uses a new routine os_process_{not_,}under_dynamorio(). A test api.static_signal is forthcoming but it still requires some other DR attach fixes before it fully works. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -49 lines)			Patch
M	core/arch/arch.c	View	4 chunks	+14 lines, -6 lines	0 comments	Download
M	core/arch/arch_exports.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/arch/interp.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/dynamo.c	View	4 chunks	+14 lines, -6 lines	0 comments	Download
M	core/os_shared.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/synch.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/unix/os.c	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	core/unix/os_exports.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	core/unix/signal.c	View	4 chunks	+53 lines, -33 lines	0 comments	Download
M	core/win32/os.c	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

10 years ago (2016-10-13 04:39:40 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/71b0060ea19a18245813e585174c678...

Final commit log: 
---------------
i#1921 native signals: remove handlers and hooks while fully native

Adds removal of all signal handler and vsyscall hooks while fully native
(during usage of the start/stop API).  This simplifies handling of native
threads.  This does not yet solve single-native-thread signals for
native_exec or DR_EMIT_GO_NATIVE.

The implementation uses a new routine os_process_{not_,}under_dynamorio().

A test api.static_signal is forthcoming but it still requires some other DR
attach fixes before it fully works.

Review-URL: https://codereview.appspot.com/308680043
---------------

Expand All Messages | Collapse All Messages