Issue 308400043: i#1569 AArch64: Add api.drdecode test for AArch64.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 308400043: i#1569 AArch64: Add api.drdecode test for AArch64. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by Edmund.Grimley.Evans

Modified:
9 years, 9 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1569 AArch64: Add api.drdecode test for AArch64. ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : Committed #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -6 lines)			Patch
M	suite/tests/CMakeLists.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	suite/tests/api/drdecode_aarch64.c	View	1	2 chunks	+22 lines, -5 lines	0 comments	Download
A	suite/tests/api/drdecode_aarch64.expect	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

If the .template is renamed .expect (no reason to waste time preprocessing it), then LGTM ...

9 years, 9 months ago (2016-09-15 19:37:49 UTC) #2

Edmund.Grimley.Evans

9 years, 9 months ago (2016-09-16 09:05:10 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/f43e120ac362eeedaca4a7a20933caf...

Final commit log: 
---------------
i#1569 AArch64: Add api.drdecode test for AArch64.

Review-URL: https://codereview.appspot.com/308400043
---------------

Expand All Messages | Collapse All Messages