i#1703 drcachesim: rename simulator to analyzer

Commit log for first patchset:
---------------
i#2006 drcachesim: add class analyzer

Add class analyzer and make class simulator inherit from class analyzer
for broader trace based analysis tools.

---------------

[bruening, 2016-09-14 19:23:39]

> i#1703 drcachesim: rename simulator to analyzer

The title makes me think you're renaming the whole simulator directory and other
uses of "simulator"

https://codereview.appspot.com/308390043/diff/1/clients/drcachesim/simulator/...
File clients/drcachesim/simulator/analyzer.h (right):

https://codereview.appspot.com/308390043/diff/1/clients/drcachesim/simulator/...
clients/drcachesim/simulator/analyzer.h:52: virtual int
core_for_thread(memref_tid_t tid);
Hmm, I guess I thought there'd still be a simulator class as a subclass of
analyzer, if there was simulator-only stuff to share.  Do the analysis tools
we're thinking of that don't care about simulating the cache hierarchy care
about thread scheduling on cores?  I don't think they do.

[zhaoqin, 2016-09-14 19:45:01]

https://codereview.appspot.com/308390043/diff/1/clients/drcachesim/simulator/...
File clients/drcachesim/simulator/analyzer.h (right):

https://codereview.appspot.com/308390043/diff/1/clients/drcachesim/simulator/...
clients/drcachesim/simulator/analyzer.h:52: virtual int
core_for_thread(memref_tid_t tid);
On 2016/09/14 19:23:39, bruening wrote:
> Hmm, I guess I thought there'd still be a simulator class as a subclass of
> analyzer, if there was simulator-only stuff to share.  Do the analysis tools
> we're thinking of that don't care about simulating the cache hierarchy care
> about thread scheduling on cores?  I don't think they do.

probably not.
will add analyzer.cpp

[zhaoqin, 2016-09-14 20:06:24]

Commit log for latest patchset:
---------------
i#1703 drcachesim: add class analyzer

Add class analyzer and make class simulator inherit from class analyzer
for broader traced based analysis tools.
---------------

[bruening, 2016-09-14 21:21:11]

> for broader traced based analysis tools.

Typo: "traced"

We decided (offline) to not keep analyzer.* in simulator/, right?  Either in
some new subdir or at top-level.

https://codereview.appspot.com/308390043/diff/20001/clients/drcachesim/simula...
File clients/drcachesim/simulator/analyzer.h (right):

https://codereview.appspot.com/308390043/diff/20001/clients/drcachesim/simula...
clients/drcachesim/simulator/analyzer.h:33: /* analyzer: represent a set of
memory trace analysis tool.
Grammar error.

But why "a set"?  Doesn't it represent just one?

[zhaoqin, 2016-09-15 03:46:25]

Commit log for latest patchset:
---------------
i#1703 drcachesim: add class analyzer

Add class analyzer and make class simulator inherit from class analyzer
for broader trace based analysis tools.
---------------

[bruening, 2016-09-15 05:21:17]

> i#1703 drcachesim: add class analyzer

This is i#2006, not i#1703.

If the i# is updated, and the #include of map is removed, then LGTM

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
File clients/drcachesim/simulator/analyzer.h (right):

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
clients/drcachesim/simulator/analyzer.h:39: #include <map>
Why is this here?

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
File clients/drcachesim/simulator/launcher.cpp (right):

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
clients/drcachesim/simulator/launcher.cpp:225: // declare the analyzer based on
its type
Note that I am working on i#1729 and am putting this code inside a conditional
checking whether traces are offline or online (so no need for you to take on
i#1729)

[zhaoqin, 2016-09-15 14:38:10]

Commit log for latest patchset:
---------------
i#1703 drcachesim: add class analyzer

Add class analyzer and make class simulator inherit from class analyzer
for broader trace based analysis tools.
---------------

[zhaoqin, 2016-09-15 14:38:25]

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
File clients/drcachesim/simulator/analyzer.h (right):

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
clients/drcachesim/simulator/analyzer.h:39: #include <map>
On 2016/09/15 05:21:17, bruening wrote:
> Why is this here?

Done.

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
File clients/drcachesim/simulator/launcher.cpp (right):

https://codereview.appspot.com/308390043/diff/40001/clients/drcachesim/simula...
clients/drcachesim/simulator/launcher.cpp:225: // declare the analyzer based on
its type
On 2016/09/15 05:21:17, bruening wrote:
> Note that I am working on i#1729 and am putting this code inside a conditional
> checking whether traces are offline or online (so no need for you to take on
> i#1729)

Acknowledged.

[zhaoqin, 2016-09-15 15:03:01]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/b11c906831411b0a7b0cc70041eb1a7...

Final commit log: 
---------------
i#2006 drcachesim: add class analyzer

Add class analyzer and make class simulator inherit from class analyzer
for broader trace based analysis tools.
---------------