Issue 308200043: TBR: i#1987 Win10-1607: add artificial version and syscall numbers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 308200043: TBR: i#1987 Win10-1607: add artificial version and syscall numbers

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by bruening

Modified:
7 years, 8 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1987 Win10-1607: add artificial version and syscall numbers Adds version checks based on the presence of NtCreateRegistryTransaction to detect the Windows 10 1607 version. Adds an artificial new version DR_WINDOWS_VERSION_10_1607 along with corresponding internal version, tools version, and libutil version, to distinguish this major update. Adds 3 new columns to the syscallx.h table and 3 new syscall arrays, selected by version check. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -97 lines)			Patch
M	api/docs/release.dox	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/lib/instrument.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/lib/instrument.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/win32/os.c	View	2 chunks	+28 lines, -8 lines	0 comments	Download
M	core/win32/os_exports.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/win32/os_private.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	core/win32/syscall.c	View	29 chunks	+57 lines, -30 lines	0 comments	Download
M	core/win32/syscallx.h	View	3 chunks	+56 lines, -56 lines	0 comments	Download
M	libutil/mfapi.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	libutil/utils.c	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	suite/tests/tools.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	suite/tests/tools.c	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 8 months ago (2016-08-24 05:24:08 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/651abf547dd8c5a69eccccdad981209...

Final commit log: 
---------------
i#1987 Win10-1607: add artificial version and syscall numbers

 Adds version checks based on the presence of NtCreateRegistryTransaction
 to detect the Windows 10 1607 version.  Adds an artificial new version
 DR_WINDOWS_VERSION_10_1607 along with corresponding internal version,
 tools version, and libutil version, to distinguish this major update.

 Adds 3 new columns to the syscallx.h table and 3 new syscall arrays,
 selected by version check.

Review-URL: https://codereview.appspot.com/308200043
---------------

Expand All Messages | Collapse All Messages