[dftimewolf] Support threading, --use_tsk and --hunt_id flags.

[dftimewolf] Support threading, --use_tsk and --hunt_id flags.

[onager, 2016-10-19 20:47:37]

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py
File dftimewolf/lib/collectors.py (right):

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:69: """Collect hunt results with GRR."""
Please add attributes section to describe public attributes of this class (see
the Plaso style guide for an example)

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:88: self.hunt = self.grr_api.Hunt(hunt_id).Get()
What happens if the hunt_id doesn't exist?

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:99: print u'{0:s} already exists:
Skipping'.format(output_file_path)
Please add more detail to this error message "not collecting files", or
something similar.

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:279: # TODO(berggren): Add flag to use TSK in some
cases.
We can probably kill this todo now ;)

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:368: approvers,
Don't call keywords args as ordinal args like this, do approvers=approvers
instead.

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:391: collector.join()
Joining with no timeout can lead to some bad behaviour, like one collector
holding up everything, or never completing. It can also be confusing to users.
Please add a todo to clean this up. 

One option would be to join with a timeout, print a status message, then join
again. If we then notice that some of the collectors are stalled while others
are completed, we can potentially abort.

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/processors.py
File dftimewolf/lib/processors.py (right):

https://codereview.appspot.com/307520043/diff/1/dftimewolf/lib/processors.py#...
dftimewolf/lib/processors.py:110: for (processor, name) in artifact_processors:
processor, _

[someguyiknow, 2016-10-20 03:44:08]

Code updated.

[onager, 2016-10-20 11:47:55]

On 2016/10/20 03:44:08, someguyiknow wrote:
> Code updated.

There are some issues here still, but I'm going to fix them myself in a followup
CL, so I'm going to merge this. LGTM.

[onager, 2016-10-20 11:49:40]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close tsk