Issue 307310043: TBR: i#95 Linux detach: merge with Windows detach

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 307310043: TBR: i#95 Linux detach: merge with Windows detach

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by bruening

Modified:
10 years, 1 month ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#95 Linux detach: merge with Windows detach Merges the Linux detach code with the Windows detach code. Keeps several OS-specific helper routines called out from the new, generalized detach code. Enables the two new app-detach tests for Windows. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+301 lines, -404 lines)			Patch
M	core/dynamo.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/options.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	core/os_shared.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	core/synch.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/synch.c	View	11 chunks	+156 lines, -49 lines	0 comments	Download
M	core/unix/os.c	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	core/unix/signal.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/win32/os.c	View	3 chunks	+108 lines, -338 lines	0 comments	Download
M	core/win32/os_exports.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	suite/tests/CMakeLists.txt	View	2 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

10 years, 1 month ago (2016-09-13 22:31:34 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/5214e9b88ed6550a8e3cc7957130efb...

Final commit log: 
---------------
i#95 Linux detach: merge with Windows detach

Merges the Linux detach code with the Windows detach code.  Keeps several
OS-specific helper routines called out from the new, generalized detach
code.  Enables the two new app-detach tests for Windows.

Review-URL: https://codereview.appspot.com/307310043
---------------

Expand All Messages | Collapse All Messages