Issue 307180043: Bug 1299792 - ssl3_PickServerSignatureScheme() shouldn't send alerts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 307180043: Bug 1299792 - ssl3_PickServerSignatureScheme() shouldn't send alerts

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by ttaubert

Modified:
7 years, 8 months ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1299792 - ssl3_PickServerSignatureScheme() shouldn't send alerts

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -19 lines)			Patch
	M	lib/ssl/ssl3con.c	View		2 chunks	+5 lines, -19 lines	0 comments	Download
	M	lib/ssl/tls13con.c	View		1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

7 years, 8 months ago (2016-09-01 13:21:49 UTC) #1

LGTM

https://codereview.appspot.com/307180043/diff/1/lib/ssl/tls13con.c
File lib/ssl/tls13con.c (right):

https://codereview.appspot.com/307180043/diff/1/lib/ssl/tls13con.c#newcode1049
lib/ssl/tls13con.c:1049: this might not be needed */
I'm sure that I had code that removed this somewhere...  Damn me for trying to
work remotely.  Ahh:

https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1295060&attachment...

Expand All Messages | Collapse All Messages