Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 306930043: Refactor TS2Dart to only generate JS Interop Facades

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by jacobr
Modified:
7 years, 8 months ago
Reviewers:
kevmoo (at google)
Base URL:
git@github.com:dart-lang/js_facade_gen.git@master
Visibility:
Public.

Description

Switch to the more limited scope task of creating JS Interop Facades allowing export of TypeScript APIs to Dart from of the far more difficult task of compiling TypeScript code to Dart code. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4595 lines, -2950 lines) Patch
D .arcconfig View 1 chunk +0 lines, -8 lines 0 comments Download
M README.md View 2 chunks +2 lines, -15 lines 0 comments Download
M gulpfile.js View 2 chunks +2 lines, -1 line 0 comments Download
M lib/base.ts View 6 chunks +192 lines, -25 lines 0 comments Download
D lib/call.ts View 1 chunk +0 lines, -212 lines 0 comments Download
A lib/dart_libraries_for_browser_types.ts View 1 chunk +981 lines, -0 lines 0 comments Download
M lib/declaration.ts View 7 chunks +622 lines, -334 lines 0 comments Download
D lib/expression.ts View 1 chunk +0 lines, -145 lines 0 comments Download
M lib/facade_converter.ts View 7 chunks +599 lines, -587 lines 0 comments Download
D lib/literal.ts View 1 chunk +0 lines, -164 lines 0 comments Download
M lib/main.ts View 14 chunks +152 lines, -90 lines 0 comments Download
A lib/merge.ts View 1 chunk +322 lines, -0 lines 0 comments Download
M lib/module.ts View 6 chunks +13 lines, -29 lines 0 comments Download
D lib/statement.ts View 1 chunk +0 lines, -173 lines 0 comments Download
M lib/type.ts View 2 chunks +19 lines, -37 lines 0 comments Download
M package.json View 2 chunks +7 lines, -8 lines 0 comments Download
M test/call_test.ts View 1 chunk +49 lines, -47 lines 0 comments Download
M test/declaration_test.ts View 4 chunks +315 lines, -112 lines 0 comments Download
M test/decorator_test.ts View 1 chunk +83 lines, -50 lines 0 comments Download
M test/e2e/helloworld.ts View 1 chunk +5 lines, -39 lines 0 comments Download
M test/e2e/lib.ts View 2 chunks +2 lines, -5 lines 0 comments Download
M test/e2e/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/expression_test.ts View 1 chunk +68 lines, -77 lines 0 comments Download
M test/facade_converter_test.ts View 3 chunks +44 lines, -379 lines 0 comments Download
M test/function_test.ts View 2 chunks +42 lines, -84 lines 0 comments Download
A test/js_interop_test.ts View 1 chunk +863 lines, -0 lines 0 comments Download
D test/literal_test.ts View 1 chunk +0 lines, -64 lines 0 comments Download
M test/main_test.ts View 1 chunk +98 lines, -100 lines 0 comments Download
M test/module_test.ts View 3 chunks +26 lines, -14 lines 0 comments Download
D test/statement_test.ts View 1 chunk +0 lines, -105 lines 0 comments Download
M test/test_support.ts View 3 chunks +7 lines, -8 lines 0 comments Download
M test/type_test.ts View 1 chunk +79 lines, -36 lines 0 comments Download
M tsconfig.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
jacobr
Still not quite happy with this code. All unittests are passing. The integration test still ...
7 years, 8 months ago (2016-08-06 00:16:32 UTC) #1
kevmoo (at google)
On 2016/08/06 00:16:32, jacobr wrote: > Still not quite happy with this code. > All ...
7 years, 8 months ago (2016-08-08 17:19:49 UTC) #2
jacobr
7 years, 8 months ago (2016-08-08 17:25:33 UTC) #3
switched review to
https://codereview.chromium.org/2225953002
and added codereview settings file.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b