LGTM https://codereview.appspot.com/306480043/diff/1/cmd/modutil/install.c File cmd/modutil/install.c (right): https://codereview.appspot.com/306480043/diff/1/cmd/modutil/install.c#newcode270 cmd/modutil/install.c:270: error(int errcode, ...) PRErrorCode is typedef'd to int, so I would use that. https://codereview.appspot.com/306480043/diff/1/external_tests/ssl_gtest/ssl_... File external_tests/ssl_gtest/ssl_record_unittest.cc (right): https://codereview.appspot.com/306480043/diff/1/external_tests/ssl_gtest/ssl_... external_tests/ssl_gtest/ssl_record_unittest.cc:6: #include "nss.h" I think that we need whitespace above this list.
https://codereview.appspot.com/306480043/diff/1/cmd/modutil/install.c File cmd/modutil/install.c (right): https://codereview.appspot.com/306480043/diff/1/cmd/modutil/install.c#newcode270 cmd/modutil/install.c:270: error(int errcode, ...) On 2016/09/12 23:59:05, mt wrote: > PRErrorCode is typedef'd to int, so I would use that. Done. https://codereview.appspot.com/306480043/diff/1/external_tests/ssl_gtest/ssl_... File external_tests/ssl_gtest/ssl_record_unittest.cc (right): https://codereview.appspot.com/306480043/diff/1/external_tests/ssl_gtest/ssl_... external_tests/ssl_gtest/ssl_record_unittest.cc:6: #include "nss.h" On 2016/09/12 23:59:05, mt wrote: > I think that we need whitespace above this list. Done.
