Issue 30620043: code review 30620043: godoc: limit concurrency to local disk filesystem

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30620043: code review 30620043: godoc: limit concurrency to local disk filesystem (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bradfitz

Modified:
11 years, 10 months ago

Reviewers:
adg

CC:
golang-dev, adg, jnj

Visibility:
Public.

Description

godoc: limit concurrency to local disk filesystem Not for Go 1.2. Still needs a flag. Linux at least (and likely other OSes) don't like you doing a few hundred readdirs at once and spawing as many threads.

Patch Set 1 #

Patch Set 2 : diff -r 575d9afb02e2 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 575d9afb02e2 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 4 : diff -r aca7c06737e1 https://code.google.com/p/go.tools #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -2 lines)			Patch
	M	cmd/godoc/main.go	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
	A	godoc/vfs/gatefs/gatefs.go	View	1 2 3	1 chunk	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 11 months ago (2013-11-22 00:31:30 UTC) #1

adg

LGTM https://codereview.appspot.com/30620043/diff/40001/godoc/vfs/gatefs/gatefs.go File godoc/vfs/gatefs/gatefs.go (right): https://codereview.appspot.com/30620043/diff/40001/godoc/vfs/gatefs/gatefs.go#newcode5 godoc/vfs/gatefs/gatefs.go:5: // Package gatefs file provides an implementation of ...

11 years, 11 months ago (2013-11-22 00:39:29 UTC) #2

jnj

https://codereview.appspot.com/30620043/diff/40001/godoc/vfs/gatefs/gatefs.go File godoc/vfs/gatefs/gatefs.go (right): https://codereview.appspot.com/30620043/diff/40001/godoc/vfs/gatefs/gatefs.go#newcode5 godoc/vfs/gatefs/gatefs.go:5: // Package gatefs file provides an implementation of the ...

11 years, 11 months ago (2013-11-22 07:36:26 UTC) #3

bradfitz

11 years, 10 months ago (2013-12-16 19:25:52 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=0014cfe5a7e9&repo=tools ***

godoc: limit concurrency to local disk filesystem

Not for Go 1.2.  Still needs a flag.

Linux at least (and likely other OSes) don't like you doing
a few hundred readdirs at once and spawing as many threads.

R=golang-dev, adg, jeremyjackins
CC=golang-dev
https://codereview.appspot.com/30620043

Expand All Messages | Collapse All Messages