Issue 306010043: DottySQL: try harder to infer column names in SELECT statements, and always make them strings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 306010043: DottySQL: try harder to infer column names in SELECT statements, and always make them strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by the80srobot

Modified:
7 years, 9 months ago

Reviewers:
scudette

CC:
rekall-dev_googlegroups.com

Base URL:
git@github.com:google/dotty.git@master

Visibility:
Public.

More Reviews

Description

DottySQL: try harder to infer column names in SELECT statements, and always make them strings. BUG= R=scudette@gmail.com Committed: 32e53fc387862aeb1b393732643a134b2a934c45

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -11 lines)			Patch
M	efilter/parsers/dottysql/parser.py	View	3 chunks	+18 lines, -6 lines	0 comments	Download
M	efilter_tests/unit/parsers/dottysql/parser.py	View	2 chunks	+22 lines, -3 lines	0 comments	Download
M	efilter_tests/unit/transforms/aslisp.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

the80srobot

7 years, 9 months ago (2016-08-01 16:08:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
32e53fc387862aeb1b393732643a134b2a934c45 (presubmit successful).

Expand All Messages | Collapse All Messages