i#513 drx_buf Part 2: drmgr_register_thread_{init,exit}_event_ex

Commit log for first patchset:
---------------
i#513 drx_buf Part 2: drmgr_register_thread_{init,exit}_event_ex

Adds priority-controlled thread init and exit events to drmgr, in the form of
drmgr_register_thread_{init,exit}_event_ex(), and associated tests.
---------------

[bruening, 2016-07-28 16:41:19]

If you could add a priority and printing and checking of the output order to the
test that would make it a much stronger test.  Shouldn't need another look so
LGTM.

Shouldn't this be part 1, not part 2, if the rest depends on this feature?

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
File suite/tests/client-interface/drmgr-test.dll.c (right):

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
suite/tests/client-interface/drmgr-test.dll.c:124:
drmgr_register_thread_exit_event_ex(event_thread_exit_ex, NULL);
It shouldn't be much work to give these priorities, have the init and init_ex
each print something, and ensure the output is in the right order?

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
suite/tests/client-interface/drmgr-test.dll.c:210: 
Please add "/* Empty. */" so we know this is deliberate.  But, see above: it
would be much better to print something and check the ordering.

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
suite/tests/client-interface/drmgr-test.dll.c:224: 
Ditto.

[toshi, 2016-07-29 02:56:05]

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
File suite/tests/client-interface/drmgr-test.dll.c (right):

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
suite/tests/client-interface/drmgr-test.dll.c:124:
drmgr_register_thread_exit_event_ex(event_thread_exit_ex, NULL);
On 2016/07/28 16:41:19, bruening wrote:
> It shouldn't be much work to give these priorities, have the init and init_ex
> each print something, and ensure the output is in the right order?

Done.

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
suite/tests/client-interface/drmgr-test.dll.c:210: 
On 2016/07/28 16:41:19, bruening wrote:
> Please add "/* Empty. */" so we know this is deliberate.  But, see above: it
> would be much better to print something and check the ordering.

Acknowledged.

https://codereview.appspot.com/305990043/diff/1/suite/tests/client-interface/...
suite/tests/client-interface/drmgr-test.dll.c:224: 
On 2016/07/28 16:41:19, bruening wrote:
> Ditto.

Acknowledged.

[toshi, 2016-07-29 03:05:25]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/18962303d9c6053bd17e2c17151bd5f...

Final commit log: 
---------------
i#513 drx_buf Part 1: drmgr_register_thread_{init,exit}_event_ex

Adds priority-controlled thread init and exit events to drmgr, in the form of
drmgr_register_thread_{init,exit}_event_ex(), and associated tests.

Review-URL: https://codereview.appspot.com/305990043
---------------