Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3803)

Issue 305700043: Musicxml2ly: Fix incorrect conversion of Minor Chords

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by pkx166h
Modified:
3 years, 2 months ago
Reviewers:
dak, david.nalesnik
CC:
lilypond-devel_gnu.org, jvromans_squirrel.nl
Visibility:
Public.

Description

Musicxml2ly: Fix incorrect conversion of Minor Chords Issue 4980 The solutions for the invalid combinations are provided in python/musicexp.py. A colon is added if a colon-less chord (i.e., major) has modifications. Adding additions checks for a trailing digit, if none, the leading period is omitted. Note that the changes in python/musicexp.py are harmless to an un-patched scripts/musicxml2ly.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M python/musicexp.py View 1 chunk +10 lines, -1 line 1 comment Download
M scripts/musicxml2ly.py View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8
pkx166h
Patch on countdown for October 11th
3 years, 2 months ago (2016-10-07 14:12:47 UTC) #1
dak
https://codereview.appspot.com/305700043/diff/1/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/305700043/diff/1/python/musicexp.py#newcode1608 python/musicexp.py:1608: # digit. If none, omit the ".". I think ...
3 years, 2 months ago (2016-10-07 14:45:54 UTC) #2
jvromans_squirrel.nl
On Fri, 07 Oct 2016 07:45:53 -0700 dak@gnu.org wrote: > https://codereview.appspot.com/305700043/diff/1/python/musicexp.py > File python/musicexp.py (right): ...
3 years, 2 months ago (2016-10-07 17:31:40 UTC) #3
pkx166h
On 2016/10/07 17:31:40, jvromans_squirrel.nl wrote: > On Fri, 07 Oct 2016 07:45:53 -0700 > mailto:dak@gnu.org ...
3 years, 2 months ago (2016-10-11 14:18:26 UTC) #4
dak
On 2016/10/07 17:31:40, jvromans_squirrel.nl wrote: > While we're at it: A couple of lines later ...
3 years, 2 months ago (2016-10-11 14:58:51 UTC) #5
jvromans_squirrel.nl
> > The bottom line is: What is required in chord c:blah so that .NN ...
3 years, 2 months ago (2016-10-12 08:28:26 UTC) #6
dak
Johan Vromans <jvromans@squirrel.nl> writes: >> > The bottom line is: What is required in chord ...
3 years, 2 months ago (2016-10-12 13:31:24 UTC) #7
david.nalesnik
3 years, 2 months ago (2016-10-12 14:00:35 UTC) #8
On Wed, Oct 12, 2016 at 5:52 AM, David Kastrup <dak@gnu.org> wrote:

> Bonus points for recognizing the fragment...

Toccata and Fugue in D minor, BWV 565?

DN

P.S. Sorry, nothing apropos the main topic!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b