Issue 305690043: TBR: Remove two non-UTF8 characters in retcheck.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 305690043: TBR: Remove two non-UTF8 characters in retcheck.c

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 7 months ago by zhaoqin

Modified:
7 years, 7 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Remove two non-UTF8 characters in retcheck.c ---------------

Patch Set 2 : Committed #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	core/arch/retcheck.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhaoqin

Committed as https://github.com/DynamoRIO/dynamorio/commit/f68d392252f001bcbf8b632600326d7430677321 Final commit log: --------------- Remove two non-UTF8 characters in retcheck.c Review-URL: https://codereview.appspot.com/305690043 ...

7 years, 7 months ago (2016-09-30 16:18:17 UTC) #2

bruening

On 2016/09/30 16:18:17, zhaoqin wrote: > Remove two non-UTF8 characters in retcheck.c The code change ...

7 years, 7 months ago (2016-09-30 18:17:16 UTC) #3

zhaoqin

7 years, 7 months ago (2016-09-30 19:00:20 UTC) #4

On 2016/09/30 18:17:16, bruening wrote:
> On 2016/09/30 16:18:17, zhaoqin wrote:
> > Remove two non-UTF8 characters in retcheck.c
> 
> The code change is good but the comment seems inaccurate: they are ascii and
> utf8 as they are single chars of code 0x18.  They are just non-printable.

sorry, I was using the error message from a build system which says non-UTF8
characters.

Expand All Messages | Collapse All Messages