Issue 305460043: Bug 1280439 - Implement RSA-PSS signature support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 305460043: Bug 1280439 - Implement RSA-PSS signature support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 7 months ago by ttaubert

Modified:
7 years, 7 months ago

Reviewers:
mt

Visibility:
Public.

More Reviews

Description

Bug 1280439 - Implement RSA-PSS signature support

Patch Set 1 #

Total comments: 6

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -66 lines)			Patch
M	external_tests/ssl_gtest/ssl_auth_unittest.cc	View	4 chunks	+9 lines, -8 lines	2 comments	Download
M	external_tests/ssl_gtest/tls_parser.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/ssl/ssl3con.c	View	28 chunks	+103 lines, -41 lines	2 comments	Download
M	lib/ssl/ssl3ecc.c	View	6 chunks	+7 lines, -8 lines	2 comments	Download
M	lib/ssl/sslimpl.h	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	lib/ssl/tls13con.c	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM https://codereview.appspot.com/305460043/diff/1/external_tests/ssl_gtest/ssl_auth_unittest.cc File external_tests/ssl_gtest/ssl_auth_unittest.cc (right): https://codereview.appspot.com/305460043/diff/1/external_tests/ssl_gtest/ssl_auth_unittest.cc#newcode76 external_tests/ssl_gtest/ssl_auth_unittest.cc:76: uint8_t sig_alg = capture->buffer().data()[offset + 1]; I would ...

7 years, 7 months ago (2016-09-13 00:40:58 UTC) #1

ttaubert

7 years, 7 months ago (2016-09-13 01:03:42 UTC) #2

https://codereview.appspot.com/305460043/diff/1/external_tests/ssl_gtest/ssl_...
File external_tests/ssl_gtest/ssl_auth_unittest.cc (right):

https://codereview.appspot.com/305460043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_auth_unittest.cc:76: uint8_t sig_alg =
capture->buffer().data()[offset + 1];
On 2016/09/13 00:40:57, mt wrote:
> I would use buffer().Read() here rather than split the two.

Done.

https://codereview.appspot.com/305460043/diff/1/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (right):

https://codereview.appspot.com/305460043/diff/1/lib/ssl/ssl3con.c#newcode7939
lib/ssl/ssl3con.c:7939: SignatureScheme sigScheme = ssl_sig_none;
On 2016/09/13 00:40:57, mt wrote:
> You can set this like with hashAlg.

Done.

https://codereview.appspot.com/305460043/diff/1/lib/ssl/ssl3ecc.c
File lib/ssl/ssl3ecc.c (right):

https://codereview.appspot.com/305460043/diff/1/lib/ssl/ssl3ecc.c#newcode628
lib/ssl/ssl3ecc.c:628: SignatureScheme sigScheme = ssl_sig_none;
On 2016/09/13 00:40:58, mt wrote:
> follow pattern of hashAlg here too

Done.

Expand All Messages | Collapse All Messages