Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3996)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 305120043: [plaso] Code clean up of knowledge base #241 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Joachim Metz
Modified:
7 years, 3 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Code clean up of knowledge base #241 Depends on: https://codereview.appspot.com/306940043/

Patch Set 1 : Changes for end-to-end tests. #

Total comments: 4

Patch Set 2 : Changes after merge. #

Patch Set 3 : Changes after merge. #

Patch Set 4 : Changes after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -356 lines) Patch
M plaso/cli/tools.py View 2 chunks +8 lines, -8 lines 0 comments Download
M plaso/containers/events.py View 5 chunks +6 lines, -8 lines 0 comments Download
M plaso/containers/sessions.py View 6 chunks +6 lines, -0 lines 0 comments Download
M plaso/engine/knowledge_base.py View 1 10 chunks +112 lines, -89 lines 0 comments Download
M plaso/frontend/extraction_frontend.py View 1 2 3 5 chunks +14 lines, -42 lines 0 comments Download
M plaso/frontend/preg.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/lib/definitions.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/output/dynamic.py View 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/output/event_buffer.py View 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/output/interface.py View 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/output/mediator.py View 1 2 3 3 chunks +17 lines, -9 lines 0 comments Download
M plaso/output/timesketch_out.py View 1 3 chunks +9 lines, -11 lines 0 comments Download
M plaso/preprocessors/interface.py View 1 2 2 chunks +14 lines, -4 lines 0 comments Download
M plaso/preprocessors/linux.py View 1 2 3 chunks +14 lines, -8 lines 0 comments Download
M plaso/preprocessors/macosx.py View 1 2 3 3 chunks +15 lines, -9 lines 0 comments Download
M plaso/preprocessors/windows.py View 1 2 4 chunks +17 lines, -11 lines 0 comments Download
M plaso/storage/zip_file.py View 1 7 chunks +25 lines, -10 lines 0 comments Download
M test_data/end_to_end/json.log View 1 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/json_line.log View 1 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/l2tcsv.log View 1 1 chunk +7 lines, -7 lines 0 comments Download
M test_data/end_to_end/l2ttln.log View 1 1 chunk +7 lines, -7 lines 0 comments Download
M test_data/end_to_end/rawpy.log View 1 37 chunks +44 lines, -44 lines 0 comments Download
M test_data/end_to_end/tln.log View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tests/analysis/test_lib.py View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M tests/containers/sessions.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/engine/knowledge_base.py View 3 chunks +190 lines, -7 lines 0 comments Download
M tests/parsers/test_lib.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/preprocessors/linux.py View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/preprocessors/macosx.py View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M tests/preprocessors/windows.py View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M tests/serializer/json_serializer.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/log2timeline.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M tools/pinfo.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/psort.py View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M tools/psteal.py View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12
Joachim Metz
7 years, 8 months ago (2016-08-07 10:03:15 UTC) #1
Joachim Metz
Code updated.
7 years, 8 months ago (2016-08-07 10:28:29 UTC) #2
onager
https://codereview.appspot.com/305120043/diff/20001/plaso/engine/knowledge_base.py File plaso/engine/knowledge_base.py (right): https://codereview.appspot.com/305120043/diff/20001/plaso/engine/knowledge_base.py#newcode77 plaso/engine/knowledge_base.py:77: session_identifier (Optional[str])): session identifier, where "current" This doesn't seem ...
7 years, 8 months ago (2016-08-14 20:18:07 UTC) #3
Joachim Metz
https://codereview.appspot.com/305120043/diff/20001/plaso/engine/knowledge_base.py File plaso/engine/knowledge_base.py (right): https://codereview.appspot.com/305120043/diff/20001/plaso/engine/knowledge_base.py#newcode77 plaso/engine/knowledge_base.py:77: session_identifier (Optional[str])): session identifier, where "current" I've changed this ...
7 years, 8 months ago (2016-08-15 05:04:59 UTC) #4
Joachim Metz
Code updated.
7 years, 8 months ago (2016-08-15 05:09:44 UTC) #5
Joachim Metz
Code updated.
7 years, 7 months ago (2016-09-24 13:42:15 UTC) #6
Joachim Metz
Code updated.
7 years, 6 months ago (2016-10-16 16:03:48 UTC) #7
Joachim Metz
Code updated.
7 years, 6 months ago (2016-10-24 19:27:12 UTC) #8
Joachim Metz
Code updated.
7 years, 5 months ago (2016-11-07 15:57:12 UTC) #9
onager
LGTM
7 years, 3 months ago (2017-01-18 17:28:54 UTC) #10
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-19 06:24:23 UTC) #11
Joachim Metz
7 years, 3 months ago (2017-01-19 06:27:27 UTC) #12 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close preprocess3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b