[plaso] Clean up of recycle.bin parser and added Windows 10 support #866

[plaso] Clean up of recycle.bin parser and added Windows 10 support #866

[onager, 2016-07-29 09:54:30]

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py
File plaso/parsers/recycler.py (right):

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:37: ascii_filename (Optional[str]): ASCII filename.
Please describe what this is.

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:75: parser_mediator (ParserMediator): parser mediator.
Please use standard docstring.

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:85: raise errors.UnableToParseFile(u'Filename does not
start with $I.')
I thought UnableToParseFile was on the path to deprecation - log error and
return?

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:175: # Limit record size to 65536 to be on the safe
side.
Remove misleading comment

[Joachim Metz, 2016-07-30 07:31:24]

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py
File plaso/parsers/recycler.py (right):

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:37: ascii_filename (Optional[str]): ASCII filename.
On 2016/07/29 09:54:30, onager wrote:
> Please describe what this is.

Done.

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:75: parser_mediator (ParserMediator): parser mediator.
actually this is the standard docstring ;)

But I'll change it to look like the other mediator docstrings.

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:85: raise errors.UnableToParseFile(u'Filename does not
start with $I.')
Agree this should directly return.

https://codereview.appspot.com/305020043/diff/1/plaso/parsers/recycler.py#new...
plaso/parsers/recycler.py:175: # Limit record size to 65536 to be on the safe
side.
On 2016/07/29 09:54:30, onager wrote:
> Remove misleading comment

Done.

[Joachim Metz, 2016-07-30 07:35:11]

Code updated.

[onager, 2016-07-30 07:44:54]

LGTM

[Joachim Metz, 2016-07-31 06:11:36]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close recycler10