Add Final Message

Add Final Message

[michelzel, 2016-08-05 21:55:20]

Hey guys,
If you could take a look at this, it would be great. If you don't have the time,
I'll just leave it here so you can add this in the near future!

[houglum, 2016-08-06 00:05:03]

+CC gsutil-crs@google.com

Mostly style/wording nits.

https://codereview.appspot.com/304380043/diff/1/gslib/tests/test_rm.py
File gslib/tests/test_rm.py (right):

https://codereview.appspot.com/304380043/diff/1/gslib/tests/test_rm.py#newcode44
gslib/tests/test_rm.py:44: final_message_pattern = 'Operation has occurred
successfully over[^\n]*'
Change "occurred" to "completed".

https://codereview.appspot.com/304380043/diff/1/gslib/tests/test_ui.py
File gslib/tests/test_ui.py (right):

https://codereview.appspot.com/304380043/diff/1/gslib/tests/test_ui.py#newcod...
gslib/tests/test_ui.py:130: final_message = ('Operation has occurred
successfully over ' +
Change "occurred" to "completed" here and below.

https://codereview.appspot.com/304380043/diff/1/gslib/ui_controller.py
File gslib/ui_controller.py (right):

https://codereview.appspot.com/304380043/diff/1/gslib/ui_controller.py#newcod...
gslib/ui_controller.py:325: string_to_print = ('Operation has occurred
successfully over %s objects'
Change "occurred" to "completed".

https://codereview.appspot.com/304380043/diff/1/gslib/ui_controller.py#newcod...
gslib/ui_controller.py:475: isinstance(status_message, FinalMessage)):
See other comment about grouping types into a tuple.

https://codereview.appspot.com/304380043/diff/1/gslib/ui_controller.py#newcod...
gslib/ui_controller.py:786: self.total_size)))
I realize this division code was already here, but:

Is there ever an instance where the SeekAheadThread would return total size of
0? If so, you might want to add a check for this to avoid a ZeroDivisonError.

https://codereview.appspot.com/304380043/diff/1/gslib/ui_controller.py#newcod...
gslib/ui_controller.py:831: isinstance(status_message, FinalMessage)):
The number of types to check against is growing; at this point, I'd recommend
grouping all the types you want to check against into a tuple, e.g.

if isinstance(thing, (class1, class2, class3)): ...

https://codereview.appspot.com/304380043/diff/1/gslib/ui_controller.py#newcod...
gslib/ui_controller.py:900: self.manager.final_message) and
self.manager.num_objects):
The indentation/parentheses make this a bit hard to read. Consider rearranging
the conditions to make the grouping a bit cleaner:

     if self.manager.num_objects and (
         isinstance(status_message, FinalMessage) or
         self.manager.final_message):

[houglum, 2016-08-06 00:18:10]

As Michel's internship ended today, we'll need to patch these changes in and
iterate on this CL separately.