Issue 304220043: [plaso] Split off engine from psort front-end #366

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1480 lines, -2188 lines)			Patch
M	plaso/analysis/tagging.py	View		4 chunks	+78 lines, -78 lines	0 comments	Download
M	plaso/cli/tools.py	View		26 chunks	+67 lines, -42 lines	0 comments	Download
M	plaso/frontend/extraction_frontend.py	View	1 2 3	13 chunks	+88 lines, -98 lines	0 comments	Download
M	plaso/frontend/psort.py	View	1 2 3 4 5	9 chunks	+130 lines, -451 lines	0 comments	Download
M	plaso/multi_processing/analysis_process.py	View	1 2	6 chunks	+35 lines, -6 lines	0 comments	Download
M	plaso/multi_processing/engine.py	View	1 2 3 4	9 chunks	+12 lines, -668 lines	0 comments	Download
A	plaso/multi_processing/psort.py	View	1 2 3 4 5	1 chunk	+489 lines, -0 lines	0 comments	Download
A +	plaso/multi_processing/task_engine.py	View	1 2 3 4	11 chunks	+9 lines, -362 lines	0 comments	Download
M	plaso/multi_processing/worker_process.py	View	1 2 3	3 chunks	+2 lines, -3 lines	0 comments	Download
M	plaso/output/null.py	View	1 2 3 4	1 chunk	+14 lines, -6 lines	0 comments	Download
M	plaso/storage/fake_storage.py	View		3 chunks	+50 lines, -0 lines	0 comments	Download
M	plaso/storage/interface.py	View		5 chunks	+52 lines, -1 line	0 comments	Download
D	plaso/storage/reader.py	View		1 chunk	+0 lines, -42 lines	0 comments	Download
M	plaso/storage/zip_file.py	View	1 2 3 4 5	2 chunks	+37 lines, -0 lines	0 comments	Download
M	tests/end-to-end.py	View	1 2 3 4 5	1 chunk	+6 lines, -1 line	0 comments	Download
M	tests/frontend/extraction_frontend.py	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/frontend/psort.py	View	1	1 chunk	+1 line, -258 lines	0 comments	Download
M	tests/frontend/test_lib.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/multi_processing/engine.py	View	1 2 3	1 chunk	+17 lines, -32 lines	0 comments	Download
A	tests/multi_processing/psort.py	View	1	1 chunk	+280 lines, -0 lines	0 comments	Download
A +	tests/multi_processing/task_engine.py	View	1 2 3	2 chunks	+6 lines, -4 lines	0 comments	Download
M	tests/storage/fake_storage.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/log2timeline.py	View		4 chunks	+12 lines, -33 lines	0 comments	Download
M	tools/psort.py	View	1 2 3 4 5	6 chunks	+84 lines, -94 lines	0 comments	Download
M	tools/psort_test.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 13

Expand All Messages | Collapse All Messages

Joachim Metz

https://codereview.appspot.com/304220043/diff/40001/plaso/multi_processing/engine.py File plaso/multi_processing/engine.py (right): https://codereview.appspot.com/304220043/diff/40001/plaso/multi_processing/engine.py#newcode440 plaso/multi_processing/engine.py:440: _RPC_SERVER_TIMEOUT = 8.0 TODO move these definitions. https://codereview.appspot.com/304220043/diff/40001/plaso/multi_processing/engine.py#newcode500 plaso/multi_processing/engine.py:500: ...

7 years, 9 months ago (2016-07-24 18:40:05 UTC) #4

onager

https://codereview.appspot.com/304220043/diff/40001/plaso/frontend/extraction_frontend.py File plaso/frontend/extraction_frontend.py (right): https://codereview.appspot.com/304220043/diff/40001/plaso/frontend/extraction_frontend.py#newcode172 plaso/frontend/extraction_frontend.py:172: engine (BaseEngine): engine to preproces the sources. preprocess https://codereview.appspot.com/304220043/diff/40001/plaso/multi_processing/engine.py ...

7 years, 9 months ago (2016-07-25 12:36:29 UTC) #5

Joachim Metz

7 years, 9 months ago (2016-07-25 17:05:04 UTC) #6

onager

docstring nits, LGTM https://codereview.appspot.com/304220043/diff/80001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/304220043/diff/80001/plaso/multi_processing/task_engine.py#newcode25 plaso/multi_processing/task_engine.py:25: """Class that defines the multi-process engine. ...

7 years, 9 months ago (2016-07-26 17:39:23 UTC) #9

Joachim Metz

https://codereview.appspot.com/304220043/diff/80001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/304220043/diff/80001/plaso/multi_processing/task_engine.py#newcode25 plaso/multi_processing/task_engine.py:25: """Class that defines the multi-process engine. On 2016/07/26 17:39:23, ...

7 years, 9 months ago (2016-07-27 05:45:07 UTC) #10

Joachim Metz

7 years, 9 months ago (2016-07-27 07:05:41 UTC) #13

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close psort3

Expand All Messages | Collapse All Messages