Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1970)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 304150043: [dfvfs] Added FileVault Disk Encryption (FVDE) support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Joachim Metz
Modified:
7 years, 8 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Added FileVault Disk Encryption (FVDE) support.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -86 lines) Patch
M dfvfs/analyzer/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A + dfvfs/analyzer/fvde_analyzer_helper.py View 3 chunks +8 lines, -8 lines 0 comments Download
M dfvfs/credentials/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A dfvfs/credentials/fvde_credentials.py View 1 chunk +22 lines, -0 lines 0 comments Download
M dfvfs/dependencies.py View 1 chunk +1 line, -0 lines 0 comments Download
A + dfvfs/file_io/fvde_file_io.py View 2 chunks +12 lines, -12 lines 0 comments Download
M dfvfs/lib/definitions.py View 2 chunks +3 lines, -1 line 0 comments Download
A dfvfs/lib/fvde.py View 1 chunk +27 lines, -0 lines 0 comments Download
M dfvfs/path/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A + dfvfs/path/fvde_path_spec.py View 3 chunks +7 lines, -7 lines 0 comments Download
M dfvfs/resolver/__init__.py View 1 chunk +6 lines, -0 lines 0 comments Download
A dfvfs/resolver/fvde_resolver_helper.py View 1 chunk +41 lines, -0 lines 0 comments Download
A dfvfs/vfs/fvde_file_entry.py View 1 chunk +42 lines, -0 lines 0 comments Download
A dfvfs/vfs/fvde_file_system.py View 1 chunk +101 lines, -0 lines 2 comments Download
A test_data/fvdetest.qcow2 View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/file_io/fvde_file_io.py View 1 chunk +68 lines, -0 lines 2 comments Download
A + tests/path/fvde_path_spec.py View 1 chunk +9 lines, -9 lines 0 comments Download
A + tests/resolver/fvde_resolver_helper.py View 1 chunk +6 lines, -6 lines 0 comments Download
A + tests/vfs/fvde_file_entry.py View 6 chunks +30 lines, -25 lines 0 comments Download
A + tests/vfs/fvde_file_system.py View 2 chunks +27 lines, -19 lines 0 comments Download

Messages

Total messages: 6
Joachim Metz
7 years, 9 months ago (2016-07-19 06:06:39 UTC) #1
Joachim Metz
https://codereview.appspot.com/304150043/diff/1/tests/file_io/fvde_file_io.py File tests/file_io/fvde_file_io.py (right): https://codereview.appspot.com/304150043/diff/1/tests/file_io/fvde_file_io.py#newcode8 tests/file_io/fvde_file_io.py:8: import pyfvde note to self catch import error.
7 years, 9 months ago (2016-07-19 06:09:58 UTC) #2
onager
https://codereview.appspot.com/304150043/diff/1/dfvfs/vfs/fvde_file_system.py File dfvfs/vfs/fvde_file_system.py (right): https://codereview.appspot.com/304150043/diff/1/dfvfs/vfs/fvde_file_system.py#newcode74 dfvfs/vfs/fvde_file_system.py:74: def GetFVDEVolume(self): Why isn't this a property?
7 years, 9 months ago (2016-07-22 15:03:09 UTC) #3
Joachim Metz
https://codereview.appspot.com/304150043/diff/1/dfvfs/vfs/fvde_file_system.py File dfvfs/vfs/fvde_file_system.py (right): https://codereview.appspot.com/304150043/diff/1/dfvfs/vfs/fvde_file_system.py#newcode74 dfvfs/vfs/fvde_file_system.py:74: def GetFVDEVolume(self): largely because of consistency with e.g. BDEFileSystem ...
7 years, 9 months ago (2016-07-23 08:26:06 UTC) #4
onager
On 2016/07/23 08:26:06, Joachim Metz wrote: > https://codereview.appspot.com/304150043/diff/1/dfvfs/vfs/fvde_file_system.py > File dfvfs/vfs/fvde_file_system.py (right): > > https://codereview.appspot.com/304150043/diff/1/dfvfs/vfs/fvde_file_system.py#newcode74 ...
7 years, 9 months ago (2016-07-23 16:21:22 UTC) #5
Joachim Metz
7 years, 8 months ago (2016-08-03 04:56:48 UTC) #6 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fvde
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b