Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 303960043: Move Output_property_engraver to Score level (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by dak
Modified:
1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move Output_property_engraver to Score level Due to the hierarchical nature of acknowledgers, acknowledgers in lower contexts will now get to see the grobs before applyOutput has done its work. However, grobs are still unfinished (except for type, properties initialized via context properties and cause) at the time they are announced, with other details only getting filled in by the engraver after announcement, so the potential for trouble seems low. Acknowledgers should usually just register a grob (or write grob data) with any actual reading of grob data occurring at the end of the timestep instead or in the process-acknowledged phase. Also contains commits: Add Output_property_engraver back to Score Run scripts/auxiliar/update-with-convert-ly.sh convert-ly rule for removing Output_property_engraver It's highly unlikely that users will redefine the Score context from scratch, so the convert-ly rule just removes every occurence of Output_property_engraver from user source. Obviously, when running the rule on the LilyPond code base, we will need to fix up the Score engraver manually to retain the Output_property_engraver .

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M Documentation/ly-examples/orchestra.ly View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/snippets/engravers-one-by-one.ly View 3 chunks +1 line, -4 lines 0 comments Download
M input/regression/spacing-to-empty-barline.ly View 2 chunks +1 line, -2 lines 0 comments Download
M lily/output-property-engraver.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M ly/engraver-init.ly View 8 chunks +1 line, -8 lines 0 comments Download
M python/convertrules.py View 1 chunk +6 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b