Issue 303660043: DCTM: Use a traverser for modified ACLs (Closed)
DescriptionUse a traverser for modified ACLs.
* Extend AclTraverser and add a new getAcls helper to override in the
new ModifiedAclTraverser subclass.
* The checkpoint was set only when the getUpdateAcls loop exited. A
first iteration failure would lead to a null checkpoint, and a later
iteration failure when return the initial checkpoint, discarding all
progress.
* Avoid uses of continue in the loop, since they would bypass updating
the checkpoint.
Related changes:
* To preserve the existing caching behavior of chronicle IDs, cache a
new chronicle ID immediately after a cache miss, and remove it when
a DfIdNotFoundException is caught.
* Add a getter and setter for checkpoint in TraverserTemplate as a
consistent way for the tests to setup an initial checkpoint and
validate the final checkpoint.
Other changes:
* Move the initialization of groupsCheckpoint in GroupTraverser from
the constructor to fillCollection, for consistency with the ACL
traversers. Also, this cleanly separates the necessary wiring of the
initial checkpoint through the constructors from the design pattern
of having TraverserTemplate provide and ask for the checkpoint when
needed.
Patch Set 1 #
Total comments: 1
Patch Set 2 : Code review change and also remove continue from getAcls. #
MessagesTotal messages: 7
|
|||||||||||||||||||||||||||||||||||||
