Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 303560043: TBR: i#95 Linux detach: generalize call_switch_stack

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by bruening
Modified:
7 years, 8 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#95 Linux detach: generalize call_switch_stack Generalizes call_switch_stack() to take any void * argument to its target function: it does not need to be a dcontext_t. This is in preparation of using other types for detach code. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M core/arch/aarch64/aarch64.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M core/arch/arch_exports.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/arch/arm/arm.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M core/arch/x86/x86.asm View 2 chunks +3 lines, -3 lines 0 comments Download
M core/arch/x86_code.c View 7 chunks +7 lines, -7 lines 0 comments Download
M core/dispatch.c View 1 chunk +1 line, -1 line 0 comments Download
M core/native_exec.c View 2 chunks +2 lines, -2 lines 0 comments Download
M core/nudge.c View 1 chunk +2 lines, -1 line 0 comments Download
M core/unix/os.c View 1 chunk +1 line, -1 line 0 comments Download
M core/unix/signal.c View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 8 months ago (2016-09-13 22:30:48 UTC) #1
bruening
7 years, 8 months ago (2016-09-13 22:30:51 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/c7524accde0f558f3f745b2e6fed8d7...

Final commit log: 
---------------
i#95 Linux detach: generalize call_switch_stack

Generalizes call_switch_stack() to take any void * argument to its target
function: it does not need to be a dcontext_t.  This is in preparation of
using other types for detach code.

Review-URL: https://codereview.appspot.com/303560043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b