code review 30340043: syscall: skip routing messages with mismatched version

syscall: skip routing messages with mismatched version

Skip routing messages with a mismatched version, rather than failing
and returning EINVAL. Only return EINVAL if we were unable to parse
any of the routing messages (presumably due to a version mismatch).

[jsing, 2013-11-22 15:50:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-11-23 16:24:16]

LGTM

Wait for Go 1.2 before submitting of course.



On Fri, Nov 22, 2013 at 7:50 AM, <jsing@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> syscall: skip routing messages with mismatched version
>
> Skip routing messages with a mismatched version, rather than failing
> and returning EINVAL. Only return EINVAL if we were unable to parse
> any of the routing messages (presumably due to a version mismatch).
>
> Please review this at https://codereview.appspot.com/30340043/
>
> Affected files (+8, -1 lines):
>   M src/pkg/syscall/route_bsd.go
>
>
> Index: src/pkg/syscall/route_bsd.go
> ===================================================================
> --- a/src/pkg/syscall/route_bsd.go
> +++ b/src/pkg/syscall/route_bsd.go
> @@ -199,14 +199,21 @@
>  // ParseRoutingMessage parses b as routing messages and returns the
>  // slice containing the RoutingMessage interfaces.
>  func ParseRoutingMessage(b []byte) (msgs []RoutingMessage, err error) {
> +       msgCount := 0
>         for len(b) >= anyMessageLen {
> +               msgCount++
>                 any := (*anyMessage)(unsafe.Pointer(&b[0]))
>                 if any.Version != RTM_VERSION {
> -                       return nil, EINVAL
> +                       b = b[any.Msglen:]
> +                       continue
>                 }
>                 msgs = append(msgs, any.toRoutingMessage(b))
>                 b = b[any.Msglen:]
>         }
> +       // We failed to parse any of the messages - version mismatch?
> +       if msgCount > 0 && len(msgs) == 0 {
> +               return nil, EINVAL
> +       }
>         return msgs, nil
>  }
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[jsing, 2013-12-10 13:03:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=17615253b9e8 ***

syscall: skip routing messages with mismatched version

Skip routing messages with a mismatched version, rather than failing
and returning EINVAL. Only return EINVAL if we were unable to parse
any of the routing messages (presumably due to a version mismatch).

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/30340043