Issue 303220043: [plaso] Removed utils.GetUnicodeString #160

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 303220043: [plaso] Removed utils.GetUnicodeString #160 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by Joachim Metz

Modified:
7 years, 9 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Removed utils.GetUnicodeString #160 Depends on: https://codereview.appspot.com/308850043/

Patch Set 2 : Removed utils.GetUnicodeString #160 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -60 lines)			Patch
M	plaso/containers/events.py	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	plaso/lib/objectfilter.py	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	plaso/lib/pfilter.py	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	plaso/lib/utils.py	View	3 chunks	+10 lines, -28 lines	0 comments	Download
M	plaso/output/event_buffer.py	View	2 chunks	+13 lines, -10 lines	0 comments	Download
M	plaso/parsers/plist.py	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	tests/lib/utils.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

onager

LGTM https://codereview.appspot.com/303220043/diff/1/plaso/lib/utils.py File plaso/lib/utils.py (right): https://codereview.appspot.com/303220043/diff/1/plaso/lib/utils.py#newcode60 plaso/lib/utils.py:60: logging.error(u'Unuppported encoding: {0:s}'.format(encoding)) Unsupported

7 years, 9 months ago (2016-08-01 07:31:54 UTC) #2

Joachim Metz

7 years, 9 months ago (2016-08-01 16:32:56 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close cleanup1

Expand All Messages | Collapse All Messages